feat: remove validation of timeline.startDate when creating a new milestone

Author: maxceem

src/routes/milestones/create.js

@@ -60,12 +60,10 @@ module.exports = [
     });
     let result;
 
-    // Validate startDate and endDate to be within the timeline startDate and endDate
+    // Validate startDate is not earlier than timeline startDate
     let error;
     if (req.body.param.startDate < req.timeline.startDate) {
       error = 'Milestone startDate must not be before the timeline startDate';
-    } else if (req.body.param.endDate && req.timeline.endDate && req.body.param.endDate > req.timeline.endDate) {
-      error = 'Milestone endDate must not be after the timeline endDate';
     }
     if (error) {
       const apiErr = new Error(error);

src/routes/milestones/create.spec.js

@@ -441,23 +441,6 @@ describe('CREATE milestone', () => {
         .expect(422, done);
     });
 
-    it('should return 422 if endDate is after the timeline endDate', (done) => {
-      const invalidBody = {
-        param: _.assign({}, body.param, {
-          endDate: '2018-06-13T00:00:00.000Z',
-        }),
-      };
-
-      request(server)
-        .post('/v4/timelines/1/milestones')
-        .set({
-          Authorization: `Bearer ${testUtil.jwts.admin}`,
-        })
-        .send(invalidBody)
-        .expect('Content-Type', /json/)
-        .expect(422, done);
-    });
-
     it('should return 422 if invalid timelineId param', (done) => {
       request(server)
         .post('/v4/timelines/0/milestones')