Merge pull request #666 from eisbilir/feature/new-milestone-concept

fix: product delete sync with ES

Author: elkhawajah

src/routes/phaseProducts/delete.js

@@ -17,7 +17,7 @@ module.exports = [
     const phaseId = _.parseInt(req.params.phaseId);
     const productId = _.parseInt(req.params.productId);
 
-    models.sequelize.transaction(() =>
+    models.sequelize.transaction(transaction =>
       // soft delete the record
       models.PhaseProduct.findOne({
         where: {
@@ -34,17 +34,17 @@ module.exports = [
           err.status = 404;
           return Promise.reject(err);
         }
-        return existing.update({ deletedBy: req.authUser.userId });
+        return existing.update({ deletedBy: req.authUser.userId }, { transaction });
       })
-        .then(entity => entity.destroy()))
+        .then(entity => entity.destroy({ transaction })))
       .then((deleted) => {
         req.log.debug('deleted phase product', JSON.stringify(deleted, null, 2));
         // emit the event
         util.sendResourceToKafkaBus(
           req,
           EVENT.ROUTING_KEY.PROJECT_PHASE_PRODUCT_REMOVED,
           RESOURCES.PHASE_PRODUCT,
-          _.pick(deleted.toJSON(), ['id', 'projectId']));
+          _.pick(deleted.toJSON(), ['id', 'projectId', 'phaseId']));
 
         res.status(204).json({});
       })