minor-fixes:

1- remove space in export/index.js
2- remove ressign lines for res & acc

Author: AliGebily

scripts/data/export/index.js

@@ -21,39 +21,40 @@ function runExportData(filePath, logger) {
       process.exit(1);
     });
 }
-  const logger = util.getAppLogger();
-  const filePath =
-    process.argv[2] === '--file' && process.argv[3]
-      ? process.argv[3]
-      : 'data/demo-data.json';
-  logger.info('Script will export data to file:', filePath);
-  // check if file exists
-  if (fs.existsSync(filePath)) {
-  // We delay question for overwrite file, because the question overlaps with a warning message from sequelize module
-  Promise.delay(1).then(() => {
-    const rl = readline.createInterface({
-      input: process.stdin,
-      output: process.stdout,
-    });
-    // confirm overwritting to file
-    rl.question(
-      'File already exists, Are you sure to overwrite it? [Y] to overwrite: ',
-      (answer) => {
-        rl.close();
-        if (answer.toLowerCase() === 'y') {
-          logger.info('File will be overwritten.');
-          runExportData(filePath, logger);
-        } else {
-          logger.info('Exit without exporting any data');
-          process.exit(0);
-        }
-      },
-    ); // question()
+
+const logger = util.getAppLogger();
+const filePath =
+  process.argv[2] === '--file' && process.argv[3]
+    ? process.argv[3]
+    : 'data/demo-data.json';
+logger.info('Script will export data to file:', filePath);
+// check if file exists
+if (fs.existsSync(filePath)) {
+// We delay question for overwrite file, because the question overlaps with a warning message from sequelize module
+Promise.delay(1).then(() => {
+  const rl = readline.createInterface({
+    input: process.stdin,
+    output: process.stdout,
   });
-  } else {
-    // get base directory of the file
-    const baseDir = path.resolve(filePath, '..');
-    // create directory recursively if it does not exist
-    util.mkdirSyncRecursive(baseDir);
-    runExportData(filePath, logger);
-  }
+  // confirm overwritting to file
+  rl.question(
+    'File already exists, Are you sure to overwrite it? [Y] to overwrite: ',
+    (answer) => {
+      rl.close();
+      if (answer.toLowerCase() === 'y') {
+        logger.info('File will be overwritten.');
+        runExportData(filePath, logger);
+      } else {
+        logger.info('Exit without exporting any data');
+        process.exit(0);
+      }
+    },
+  ); // question()
+});
+} else {
+  // get base directory of the file
+  const baseDir = path.resolve(filePath, '..');
+  // create directory recursively if it does not exist
+  util.mkdirSyncRecursive(baseDir);
+  runExportData(filePath, logger);
+}

src/middlewares/performanceRequestLogger.js

@@ -11,8 +11,7 @@ module.exports = function logRequest(logger) {
   }
 
   // Use the logger with memory usage info
-  return (req, response, next) => {
-    const res = response;
+  return (req, res, next) => {
     const startOpts = {
       method: req.method,
       url: req.url,

src/middlewares/validateTimeline.js

@@ -7,7 +7,7 @@ import util from '../util';
 /**
  * Common validation code for types of timeline references.
  * @param {{ reference: string, referenceId: string|number }} sourceObject
- * @param {object} request
+ * @param {object} req
  * @param {boolean} [validateProjectExists]
  * @returns {Promise}
  */

src/permissions/project.delete.js

@@ -6,14 +6,13 @@ import { PROJECT_MEMBER_ROLE } from '../constants';
 /**
  * Super admin, Topcoder Managers are allowed to edit any project
  * Rest can add members only if they are currently part of the project team.
- * @param {Object}    freq        the express request instance
+ * @param {Object}    req        the express request instance
  * @return {Promise}              Returns a promise
  */
-module.exports = freq => new Promise((resolve, reject) => {
-  const projectId = _.parseInt(freq.params.projectId);
+module.exports = req => new Promise((resolve, reject) => {
+  const projectId = _.parseInt(req.params.projectId);
   return models.ProjectMember.getActiveProjectMembers(projectId)
       .then((members) => {
-        const req = freq;
         req.context = req.context || {};
         req.context.currentProjectMembers = members;
         // check if auth user has acecss to this project

src/util.js

@@ -765,8 +765,7 @@ _.assignIn(util, {
     }
 
     // set default null value for all valid fields
-    const memberDefaults = _.reduce(fields, (ac, field) => {
-      const acc = ac;
+    const memberDefaults = _.reduce(fields, (acc, field) => {
       const isValidField = _.includes(_.union(memberDetailFields, memberTraitFields), field);
       if (isValidField) {
         acc[field] = null;