Skip to content

[HOTFIX] [DEV] email user photo size, part 2 #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 29, 2020
Merged

[HOTFIX] [DEV] email user photo size, part 2 #194

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc13318
fix: don't reassign event data
Apr 29, 2020
cb65347
Revert "fix: don't reassign event data"
Apr 29, 2020
eb38194
fix: photo URL
Apr 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions connect/notificationServices/email.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,8 +237,6 @@ function handler(topicName, messageJSON, notification) {
projectId: messageJSON.projectId,
authorHandle: notification.contents.userHandle,
authorFullName: notification.contents.userFullName,
photoURL: `${config.TC_CDN_URL}/avatar/${encodeURIComponent(notification.contents.photoURL)}`
+ `?size=${EMAIL_USER_PHOTO_SIZE}`,
type: notificationType,
emailToAffectedUser: notification.contents.userEmail === userEmail,
},
Expand All @@ -252,6 +250,9 @@ function handler(topicName, messageJSON, notification) {
};
eventMessage.data[eventMessage.data.type] = true;
_.assign(eventMessage.data, notification.contents);
// set `photoURL` after we already applied `notification.contents`, so `photoURL` doesn't get overwritten
eventMessage.data.photoURL = `${config.TC_CDN_URL}/avatar/${encodeURIComponent(notification.contents.photoURL)}`
+ `?size=${EMAIL_USER_PHOTO_SIZE}`;

// message service may return tags
// to understand if post notification is regarding phases or no, we will try to get phaseId from the tags
Expand Down