Skip to content

[HOTFIX] [DEV] email user photo size #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 29, 2020
Merged

[HOTFIX] [DEV] email user photo size #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f5b4fc7
Merge pull request #181 from topcoder-platform/dev
Mar 2, 2020
0ded256
Merge pull request #184 from topcoder-platform/dev
Mar 23, 2020
34e23e7
Merge pull request #187 from topcoder-platform/dev
Mar 26, 2020
70eb318
fix: resize email user photo size to 80
maxceem Apr 13, 2020
b98052f
chore: remove config files with real values
Apr 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions config/default.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ module.exports = {
API_CONTEXT_PATH: process.env.API_CONTEXT_PATH || '/v5/notifications',
TC_API_BASE_URL: process.env.TC_API_BASE_URL || '',

// CloudFront CDN URL. It's used to host and resize images like user avatars.
TC_CDN_URL: process.env.TC_CDN_URL || '',

// Configuration for generating machine to machine auth0 token.
// The token will be used for calling another internal API.
AUTH0_URL: process.env.AUTH0_URL,
Expand Down
3 changes: 3 additions & 0 deletions connect/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
module.exports = {
// size for user photos in emails
EMAIL_USER_PHOTO_SIZE: 80,

// periods of time in cron format (node-cron)
SCHEDULED_EVENT_PERIOD: {
every10minutes: '*/10 * * * *',
Expand Down
4 changes: 3 additions & 1 deletion connect/notificationServices/email.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ const {
SCHEDULED_EVENT_PERIOD,
SETTINGS_EMAIL_SERVICE_ID,
ACTIVE_USER_STATUSES,
EMAIL_USER_PHOTO_SIZE,
} = require('../constants');
const { EVENT_BUNDLES } = require('../events-config');
const helpers = require('../helpers');
Expand Down Expand Up @@ -236,7 +237,8 @@ function handler(topicName, messageJSON, notification) {
projectId: messageJSON.projectId,
authorHandle: notification.contents.userHandle,
authorFullName: notification.contents.userFullName,
photoURL: notification.contents.photoURL,
photoURL: `${config.TC_CDN_URL}/avatar/${encodeURIComponent(notification.contents.photoURL)}`
+ `?size=${EMAIL_USER_PHOTO_SIZE}`,
type: notificationType,
emailToAffectedUser: notification.contents.userEmail === userEmail,
},
Expand Down