Merge pull request #122 from topcoder-platform/hotfix/handling_unhandled_error_in_getting_mentioned_user_details

Hotfix/handling unhandled error in getting mentioned user details

Author: vikasrohit

connect/connectNotificationServer.js

@@ -95,14 +95,14 @@ const getNotificationsForMentionedUser = (logger, eventConfig, content) => {
           notification.userId = mentionedUser ? mentionedUser.userId.toString() : notification.userHandle;
         });
         resolve(notifications);
-      }).catch((error) => {
+      })/*.catch((error) => {
         if (logger) {
           logger.error(error);
           logger.info('Unable to send notification to mentioned user')
         }
         //resolves with empty notification which essentially means we are unable to send notification to mentioned user
         resolve([]);
-      });
+      })*/;
     } else {
       resolve([]);
     }

src/app.js

@@ -76,14 +76,17 @@ function startKafkaConsumer(handlers, notificationServiceHandlers) {
   });
 
   const check = function () {
+    logger.debug('Checking Health...')   ; 
     if (!consumer.client.initialBrokers && !consumer.client.initialBrokers.length) {
+      logger.debug('Found unhealthy Kafka Brokers...');
       return false;
     }
     let connected = true;
     consumer.client.initialBrokers.forEach(conn => {
       logger.debug(`url ${conn.server()} - connected=${conn.connected}`);
       connected = conn.connected & connected;
     });
+    logger.debug('Found all Kafka Brokers healthy...');
     return connected;
   };