chore: move MAX dates to migration script from common config

Author: maxceem

config/default.js

@@ -135,9 +135,5 @@ module.exports = {
   // the URL where TaaS App is hosted
   TAAS_APP_URL: process.env.TAAS_APP_URL || 'https://platform.topcoder-dev.com/taas/myteams',
   // default time zone for Work Periods
-  WORK_PERIOD_TIME_ZONE: process.env.WORK_PERIOD_TIME_ZONE || 'America/New_York',
-  // maximum start date of resource bookings when populating work periods from existing resource bookings in migration script
-  MAX_START_DATE: process.env.MAX_START_DATE || '2100-12-31',
-  // maximum end date of resource bookings when populating work periods from existing resource bookings in migration script
-  MAX_END_DATE: process.env.MAX_END_DATE || '2100-12-31'
+  WORK_PERIOD_TIME_ZONE: process.env.WORK_PERIOD_TIME_ZONE || 'America/New_York'
 }

migrations/2021-04-10-populate-work-periods-for-resource-bookings.js

@@ -4,6 +4,11 @@ const _ = require('lodash')
 const helper = require('../src/common/helper')
 const { v4: uuid } = require('uuid')
 
+// maximum start date of resource bookings when populating work periods from existing resource bookings in migration script
+const MAX_START_DATE = process.env.MAX_START_DATE || '2100-12-31'
+// maximum end date of resource bookings when populating work periods from existing resource bookings in migration script
+const MAX_END_DATE = process.env.MAX_END_DATE || '2100-12-31'
+
 /*
  * Populate WorkPeriods for ResourceBookings
  */
@@ -15,8 +20,8 @@ module.exports = {
     try {
       const resourceBookings = await ResourceBooking.findAll({
         where: {
-          start_date: { [Op.lt]: new Date(config.MAX_START_DATE) },
-          end_date: { [Op.lt]: new Date(config.MAX_END_DATE) }
+          start_date: { [Op.lt]: new Date(MAX_START_DATE) },
+          end_date: { [Op.lt]: new Date(MAX_END_DATE) }
         }
       })
       if (resourceBookings.length === 0) {
@@ -57,8 +62,8 @@ module.exports = {
       const Op = Sequelize.Op
       const resourceBookings = await ResourceBooking.findAll({
         where: {
-          start_date: { [Op.lt]: new Date(config.MAX_START_DATE) },
-          end_date: { [Op.lt]: new Date(config.MAX_END_DATE) }
+          start_date: { [Op.lt]: new Date(MAX_START_DATE) },
+          end_date: { [Op.lt]: new Date(MAX_END_DATE) }
         },
         // include soft-deleted resourceBookings
         paranoid: false