Merge pull request #387 from yoution/roles-tweaks-bugs

Role Skills Intake - Tweaks and Bugs

Author: nikolay83

src/routes/RoleRoutes.js

@@ -13,13 +13,13 @@ module.exports = {
     },
     get: {
       controller: 'RoleController',
-      method: 'searchRoles',
+      method: 'searchRoles'
     }
   },
   '/taas-roles/:id': {
     get: {
       controller: 'RoleController',
-      method: 'getRole',
+      method: 'getRole'
     },
     patch: {
       controller: 'RoleController',

src/services/JobCandidateService.js

@@ -203,14 +203,14 @@ fullyUpdateJobCandidate.schema = Joi.object()
       .keys({
         jobId: Joi.string().uuid().required(),
         userId: Joi.string().uuid().required(),
-        status: Joi.jobCandidateStatus().default("open"),
+        status: Joi.jobCandidateStatus().default('open'),
         externalId: Joi.string().allow(null).default(null),
-        resume: Joi.string().uri().allow("").allow(null).default(null),
+        resume: Joi.string().uri().allow('').allow(null).default(null),
         remark: Joi.stringAllowEmpty().allow(null)
       })
-      .required(),
+      .required()
   })
-  .required();
+  .required()
 
 /**
  * Delete jobCandidate by id

src/services/JobService.js

@@ -294,11 +294,11 @@ partiallyUpdateJob.schema = Joi.object()
         jobLocation: Joi.stringAllowEmpty().allow(null),
         jobTimezone: Joi.stringAllowEmpty().allow(null),
         currency: Joi.stringAllowEmpty().allow(null),
-        roleIds: Joi.array().items(Joi.string().uuid().required()).allow(null),
+        roleIds: Joi.array().items(Joi.string().uuid().required()).allow(null)
       })
-      .required(),
+      .required()
   })
-  .required();
+  .required()
 
 /**
  * Fully update job by id

src/services/TeamService.js

@@ -789,7 +789,7 @@ roleSearchRequest.schema = Joi.object()
     currentUser: Joi.object(),
     data: Joi.object().keys({
       roleId: Joi.string().uuid(),
-      jobDescription: Joi.string().max(255),
+      jobDescription: Joi.string().max(2000),
       skills: Joi.array().items(Joi.string().uuid().required()),
       jobTitle: Joi.string().max(100),
       previousRoleSearchRequestId: Joi.string().uuid()
@@ -864,6 +864,12 @@ async function getSkillsByJobDescription (data) {
       if (skill.pattern.test(word)) {
         foundSkills.push(skill.name)
       }
+      // for suffix with 'js'
+      if (!word.endsWith('js') && skill.name.endsWith('js')) {
+        if (skill.pattern.test(word + 'js')) {
+          foundSkills.push(skill.name)
+        }
+      }
     })
   })
   foundSkills = _.uniq(foundSkills)