refactor: rename fromDB option for internal usage

Author: maxceem

src/services/ResourceBookingService.js

@@ -546,7 +546,8 @@ async function searchResourceBookings (currentUser, criteria, options) {
   if (!criteria.sortOrder) {
     criteria.sortOrder = 'desc'
   }
-  if (!options.fromDb) {
+  // this option to return data from DB is only for internal usage, and it cannot be passed from the endpoint
+  if (!options.returnFromDB) {
     try {
       const esQuery = {
         index: config.get('esConfig.ES_INDEX_RESOURCE_BOOKING'),
@@ -849,7 +850,7 @@ searchResourceBookings.schema = Joi.object().keys({
     fromDb: Joi.boolean().default(false)
   }).default({
     returnAll: false,
-    fromDb: false
+    returnFromDB: false
   })
 }).required()
 

src/services/WorkPeriodPaymentService.js

@@ -405,7 +405,7 @@ async function createQueryWorkPeriodPayments (currentUser, criteria) {
     ['id', 'billingAccountId', 'memberRate', 'customerRate', 'workPeriods.id', 'workPeriods.resourceBookingId', 'workPeriods.daysWorked', 'workPeriods.daysPaid'],
     _.map(_.keys(query), k => k === 'projectIds' ? 'projectId' : k))
   ), ',')
-  const searchResult = await searchResourceBookings(currentUser, _.extend({ fields, page: 1 }, query), { returnAll: true, fromDb: true })
+  const searchResult = await searchResourceBookings(currentUser, _.extend({ fields, page: 1 }, query), { returnAll: true, returnFromDB: true })
 
   const wpArray = _.flatMap(searchResult.result, 'workPeriods')
   const resourceBookingMap = _.fromPairs(_.map(searchResult.result, rb => [rb.id, rb]))