Merge pull request #361 from topcoder-platform/change-validatations-in-job-jc

Change validatations in job jc

Author: sushilshinde

src/services/JobCandidateService.js

@@ -195,18 +195,22 @@ async function fullyUpdateJobCandidate (currentUser, id, data) {
   return updateJobCandidate(currentUser, id, data)
 }
 
-fullyUpdateJobCandidate.schema = Joi.object().keys({
-  currentUser: Joi.object().required(),
-  id: Joi.string().uuid().required(),
-  data: Joi.object().keys({
-    jobId: Joi.string().uuid().required(),
-    userId: Joi.string().uuid().required(),
-    status: Joi.jobCandidateStatus().default('open'),
-    externalId: Joi.string().allow(null).default(null),
-    resume: Joi.string().uri().allow('').allow(null).default(null),
-    remark: Joi.string().allow('').allow(null).default(null)
-  }).required()
-}).required()
+fullyUpdateJobCandidate.schema = Joi.object()
+  .keys({
+    currentUser: Joi.object().required(),
+    id: Joi.string().uuid().required(),
+    data: Joi.object()
+      .keys({
+        jobId: Joi.string().uuid().required(),
+        userId: Joi.string().uuid().required(),
+        status: Joi.jobCandidateStatus().default("open"),
+        externalId: Joi.string().allow(null).default(null),
+        resume: Joi.string().uri().allow("").allow(null).default(null),
+        remark: Joi.stringAllowEmpty().allow(null),
+      })
+      .required(),
+  })
+  .required();
 
 /**
  * Delete jobCandidate by id

src/services/JobService.js

@@ -208,9 +208,9 @@ createJob.schema = Joi.object()
         minSalary: Joi.number().integer().allow(null),
         maxSalary: Joi.number().integer().allow(null),
         hoursPerWeek: Joi.number().integer().allow(null),
-        jobLocation: Joi.string().allow(null).allow(''),
-        jobTimezone: Joi.string().allow(null).allow(''),
-        currency: Joi.string().allow(null).allow(''),
+        jobLocation: Joi.stringAllowEmpty().allow(null),
+        jobTimezone: Joi.stringAllowEmpty().allow(null),
+        currency: Joi.stringAllowEmpty().allow(null),
         roleIds: Joi.array().items(Joi.string().uuid().required())
       })
       .required()