Sync billing account id to direct project (legacy)

[vikasrohit]

If v5 project has [billingAccountId](https://github.com/topcoder-platform/tc-project-service/blob/develop/src/models/project.js#L10) in the payload, it should be synced to the legacy project https://github.com/topcoder-platform/legacy-project-processor/blob/develop/src/services/ProcessorService.js#L189 and https://github.com/topcoder-platform/legacy-project-processor/blob/develop/src/services/ProcessorService.js#L359.

[vikasrohit]

fyi @maxceem , we can plan it in current release.

[maxceem]

@vikasrohit I've got a clarification from one of the members who worked on this processor, this functionality looks like already implemented, does it have issues?
https://github.com/topcoder-platform/legacy-project-processor/blob/develop/src/services/ProcessorService.js#L414
https://github.com/topcoder-platform/legacy-project-processor/blob/develop/src/services/ProcessorService.js#L438-L443
https://github.com/topcoder-platform/legacy-project-processor/blob/develop/src/services/ProcessorService.js#L465-L467

[vikasrohit]

Ohk, if it is already there, we just need to verify it. I haven't verified it yet.

[maxceem]

@vikasrohit looks like this works, right?

[vikasrohit]

Verified, it is working fine. However, we might need some improvements.

1. We can avoid making query to the database if the userId is negative

   legacy-project-processor/src/services/ProcessorService.js

   Line 76 in 8f7cf1a

   const handleRes = await connection.queryAsync(`select handle from common_oltp:user where user_id = ${userId}`)

2. And as you said in Handle negative user id (m2m user) in project.action.update event #12, we can avoid throwing error and instead just return null handle when either userId is a negative number OR we don't find the user with the given user id in the database and don't make the query

   legacy-project-processor/src/services/ProcessorService.js

   Line 97 in 8f7cf1a

   directAccessIds = await connection.queryAsync(`select p.project_id as id from time_oltp:project as p left join time_oltp:client_project as cp on p.project_id = cp.project_id left join time_oltp:client c on c.client_id = cp.client_id and (c.is_deleted = 0 or c.is_deleted is null) where p.active = 1 and p.start_date <= current and current <= p.end_date and p.active = 1 and p.project_id in (SELECT distinct project_id FROM time_oltp:project_manager p, time_oltp:user_account u WHERE p.user_account_id = u.user_account_id and p.active = 1 and upper(u.user_name) = upper('${userName}') union SELECT distinct project_id FROM time_oltp:project_worker p, time_oltp:user_account u WHERE p.start_date <= current and current <= p.end_date and p.active =1 and p.user_account_id = u.user_account_id and upper(u.user_name) = upper('${userName}'))`)

   if returned handle is null.
3. Also, we might need to allow syncing the old billing account. Right now at

   legacy-project-processor/src/services/ProcessorService.js

   Line 97 in 8f7cf1a

   directAccessIds = await connection.queryAsync(`select p.project_id as id from time_oltp:project as p left join time_oltp:client_project as cp on p.project_id = cp.project_id left join time_oltp:client c on c.client_id = cp.client_id and (c.is_deleted = 0 or c.is_deleted is null) where p.active = 1 and p.start_date <= current and current <= p.end_date and p.active = 1 and p.project_id in (SELECT distinct project_id FROM time_oltp:project_manager p, time_oltp:user_account u WHERE p.user_account_id = u.user_account_id and p.active = 1 and upper(u.user_name) = upper('${userName}') union SELECT distinct project_id FROM time_oltp:project_worker p, time_oltp:user_account u WHERE p.start_date <= current and current <= p.end_date and p.active =1 and p.user_account_id = u.user_account_id and upper(u.user_name) = upper('${userName}'))`)

   we have where p.active = 1 and p.start_date <= current and current <= p.end_date and p.active = 1 as filter which is correct theoretically but I can see some of our API callers might be trying to associate a billing account which has ended because they might get that billing account renewed soon.

[vikasrohit]

I think 1 and 2 belongs to #12 and 3 is not that critical for now, so lets close this issue. I am filing a new one with 3 only and moving 1 and 2 to #12.