Skip to content

Conversation

@GHPS
Copy link
Contributor

@GHPS GHPS commented Apr 10, 2021

No description provided.

@codecov
Copy link

codecov bot commented Apr 10, 2021

Codecov Report

Merging #675 (60d8230) into master (336e050) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #675      +/-   ##
==========================================
- Coverage   75.95%   75.78%   -0.17%     
==========================================
  Files           8        8              
  Lines        1181     1181              
  Branches      295      295              
==========================================
- Hits          897      895       -2     
- Misses        204      205       +1     
- Partials       80       81       +1     
Impacted Files Coverage Δ
tmuxp/cli.py 73.34% <100.00%> (-0.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 336e050...60d8230. Read the comment docs.

@tony
Copy link
Member

tony commented Jul 2, 2021

Thank you for the PR! Can you rebase?

@tony
Copy link
Member

tony commented Jul 2, 2021

Is it possible to add a test to test_cli.py too?

@GHPS
Copy link
Contributor Author

GHPS commented Jul 8, 2021

Thanks for your reply!

Thank you for the PR! Can you rebase?

Since the PR is just a single line of code changed it perhaps makes
sense to simply copy it over...

Is it possible to add a test to test_cli.py too?

Yes - but currently there is no test targeting the help system (the --help option).
I'm not sure what would be the best test to ensure that the help system is working.
The help menu? That would have to change with every UI change.

@tony
Copy link
Member

tony commented Jul 8, 2021

Since the PR is just a single line of code changed it perhaps makes
sense to simply copy it over...

Of course, whatever you'd think would make a clean commit to merge :)

For the test: You can take a look in test_cli.py to see how we assert, You can assert the stdout, for instance, and check if Usage: is at the top for -h, --help`, etc. if it's too much effort, no problem i can take care of it. :)

@GHPS
Copy link
Contributor Author

GHPS commented Jul 15, 2021

I've just rebased the commit and created two tests to verify that --help and -h work correctly.

The changes are in PR#700.

@tony
Copy link
Member

tony commented Jul 15, 2021

@GHPS What commands did you use to rebase? There's still a conflict

What does git remote -v show btw? I can give you the commands to run.

@GHPS
Copy link
Contributor Author

GHPS commented Jul 16, 2021

There's still a conflict.

Seriously? Or are you looking at the same old conflict (f4c9fc2)?

Please take PR700 to merge - it is based on the latest source base.

@GHPS GHPS closed this Jul 16, 2021
@tony
Copy link
Member

tony commented Jul 16, 2021

Moved to #700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants