refactor(cli[utils]): Remove _get_abs_path

Author: tony

src/tmuxp/cli/import_config.py

@@ -7,14 +7,7 @@
 from tmuxp.config_reader import ConfigReader
 
 from .. import config
-from .utils import (
-    get_abs_path,
-    prompt,
-    prompt_choices,
-    prompt_yes_no,
-    scan_config,
-    tmuxp_echo,
-)
+from .utils import prompt, prompt_choices, prompt_yes_no, scan_config, tmuxp_echo
 
 
 def get_tmuxinator_dir() -> str:
@@ -55,10 +48,10 @@ def get_teamocil_dir() -> str:
 
 
 def _resolve_path_no_overwrite(config: str) -> str:
-    path = get_abs_path(config)
-    if os.path.exists(path):
+    path = pathlib.Path(config).resolve()
+    if path.exists():
         raise ValueError("%s exists. Pick a new filename." % path)
-    return path
+    return str(path)
 
 
 def command_import(

src/tmuxp/cli/utils.py

@@ -63,19 +63,6 @@ def get_config_dir() -> str:
     return path
 
 
-def get_abs_path(config: str) -> str:
-    path = os.path
-    join, isabs = path.join, path.isabs
-    dirname, normpath = path.dirname, path.normpath
-    cwd = os.getcwd()
-
-    config = os.path.expanduser(config)
-    if not isabs(config) or len(dirname(config)) > 1:
-        config = normpath(join(cwd, config))
-
-    return config
-
-
 def scan_config(
     config: t.Union[pathlib.Path, str],
     config_dir: t.Optional[t.Union[pathlib.Path, str]] = None,

tests/test_cli.py

@@ -23,13 +23,7 @@
     load_plugins,
     load_workspace,
 )
-from tmuxp.cli.utils import (
-    get_abs_path,
-    get_config_dir,
-    is_pure_name,
-    scan_config,
-    tmuxp_echo,
-)
+from tmuxp.cli.utils import get_config_dir, is_pure_name, scan_config, tmuxp_echo
 from tmuxp.config_reader import ConfigReader
 from tmuxp.workspacebuilder import WorkspaceBuilder
 
@@ -1126,13 +1120,15 @@ def test_freeze_overwrite(
     assert yaml_config_path.exists()
 
 
-def test_get_abs_path(tmp_path: pathlib.Path, monkeypatch: pytest.MonkeyPatch) -> None:
+def test_resolve_behavior(
+    tmp_path: pathlib.Path, monkeypatch: pytest.MonkeyPatch
+) -> None:
     expect = str(tmp_path)
     monkeypatch.chdir(tmp_path)
-    get_abs_path("../") == os.path.dirname(expect)
-    get_abs_path(".") == expect
-    get_abs_path("./") == expect
-    get_abs_path(expect) == expect
+    pathlib.Path("../").resolve() == os.path.dirname(expect)
+    pathlib.Path(".").resolve() == expect
+    pathlib.Path("./").resolve() == expect
+    pathlib.Path(expect).resolve() == expect
 
 
 def test_get_tmuxinator_dir(monkeypatch: pytest.MonkeyPatch) -> None: