feat(builder): allow environments for windows and panes

This fixes #832.

Author: zappolowski

src/tmuxp/workspace/builder.py

@@ -7,6 +7,7 @@
 import logging
 import time
 
+from libtmux.common import has_gte_version
 from libtmux.exc import TmuxSessionExists
 from libtmux.pane import Pane
 from libtmux.server import Server
@@ -346,12 +347,22 @@ def iter_create_windows(self, session, append=False):
             except (KeyError, IndexError):
                 pass
 
+            if has_gte_version("3.0"):
+                environment = panes[0].get("environment", wconf.get("environment"))
+            else:
+                logging.warning(
+                    "Cannot set environment for new window. "
+                    "You need tmux 3.0 or newer for this."
+                )
+                environment = {}
+
             w = session.new_window(
                 window_name=window_name,
                 start_directory=sd,
                 attach=False,  # do not move to the new window
                 window_index=wconf.get("window_index", ""),
                 window_shell=ws,
+                environment=environment,
             )
 
             if is_first_window_pass:  # if first window, use window 1
@@ -418,11 +429,21 @@ def get_pane_shell():
                     else:
                         return None
 
+                if has_gte_version("3.0"):
+                    environment = pconf.get("environment", wconf.get("environment"))
+                else:
+                    logging.warning(
+                        "Cannot set environment for new pane. "
+                        "You need tmux 3.0 or newer for this."
+                    )
+                    environment = {}
+
                 p = w.split_window(
                     attach=True,
                     start_directory=get_pane_start_directory(),
                     shell=get_pane_shell(),
                     target=p.id,
+                    environment=environment,
                 )
 
             assert isinstance(p, Pane)

tests/fixtures/workspace/builder/environment_vars.yaml

@@ -1,9 +1,27 @@
 session_name: test env vars
 start_directory: '~'
 environment:
-  FOO: BAR
+  FOO: SESSION
   PATH: /tmp
+options:
+  default-shell: /bin/sh
 windows:
-- window_name: editor
+- window_name: no_overrides
   panes:
   - pane
+- window_name: window_overrides
+  environment:
+    FOO: WINDOW
+  panes:
+  - pane
+- window_name: pane_overrides
+  panes:
+  - environment:
+      FOO: PANE
+- window_name: both_overrides
+  environment:
+    FOO: WINDOW
+  panes:
+  - pane
+  - environment:
+      FOO: PANE

tests/workspace/test_builder.py

@@ -9,6 +9,7 @@
 
 import libtmux
 from libtmux.common import has_gte_version, has_lt_version
+from libtmux.session import Session
 from libtmux.test import retry_until, temp_session
 from libtmux.window import Window
 from tmuxp import exc
@@ -331,6 +332,10 @@ def f():
         assert w.name != "top"
 
 
+@pytest.mark.skipif(
+    has_lt_version("3.0"),
+    reason="needs -e flag for new-window and split-window introduced in tmux 3.0",
+)
 def test_environment_variables(session):
     workspace = ConfigReader._from_file(
         test_utils.get_workspace_file("workspace/builder/environment_vars.yaml")
@@ -340,9 +345,68 @@ def test_environment_variables(session):
     builder = WorkspaceBuilder(sconf=workspace)
     builder.build(session)
 
-    assert session.getenv("FOO") == "BAR"
+    assert session.getenv("FOO") == "SESSION"
+    assert session.getenv("PATH") == "/tmp"
+
+    no_overrides_win = session.windows[0]
+    pane = no_overrides_win.panes[0]
+    pane.send_keys("echo $FOO")
+    assert pane.capture_pane()[1] == "SESSION"
+
+    window_overrides_win = session.windows[1]
+    pane = window_overrides_win.panes[0]
+    pane.send_keys("echo $FOO")
+    assert pane.capture_pane()[1] == "WINDOW"
+
+    pane_overrides_win = session.windows[2]
+    pane = pane_overrides_win.panes[0]
+    pane.send_keys("echo $FOO")
+    assert pane.capture_pane()[1] == "PANE"
+
+    both_overrides_win = session.windows[3]
+    pane = both_overrides_win.panes[0]
+    pane.send_keys("echo $FOO")
+    assert pane.capture_pane()[1] == "WINDOW"
+    pane = both_overrides_win.panes[1]
+    pane.send_keys("echo $FOO")
+    assert pane.capture_pane()[1] == "PANE"
+
+
+@pytest.mark.skipif(
+    has_gte_version("3.0"),
+    reason="warnings are not needed for tmux >= 3.0",
+)
+def test_environment_variables_logs(session: Session, caplog: pytest.LogCaptureFixture):
+    workspace = ConfigReader._from_file(
+        test_utils.get_workspace_file("workspace/builder/environment_vars.yaml")
+    )
+    workspace = loader.expand(workspace)
+
+    builder = WorkspaceBuilder(sconf=workspace)
+    builder.build(session)
+
+    # environment on sessions should work as this is done using set-environment
+    # on the session itself
+    assert session.getenv("FOO") == "SESSION"
     assert session.getenv("PATH") == "/tmp"
 
+    assert (
+        sum(
+            1
+            for record in caplog.records
+            if "Cannot set environment for new window." in record.msg
+        )
+        == 4
+    ), "Warning on creating windows missing"
+    assert (
+        sum(
+            1
+            for record in caplog.records
+            if "Cannot set environment for new pane." in record.msg
+        )
+        == 1
+    ), "Warning on creating panes missing"
+
 
 def test_automatic_rename_option(session):
     """With option automatic-rename: on."""