Operator factor settings should have the OperatorDynamic setting property (elastic#83359)

Relates elastic#82819

Author: tlrx

server/src/main/java/org/elasticsearch/indices/recovery/RecoverySettings.java

@@ -104,14 +104,12 @@ public class RecoverySettings {
         DEFAULT_FACTOR_VALUE
     );
 
-    public static final Setting<Double> NODE_BANDWIDTH_RECOVERY_OPERATOR_FACTOR_WRITE_SETTING = factorSetting(
-        "node.bandwidth.recovery.operator.factor.write",
-        NODE_BANDWIDTH_RECOVERY_OPERATOR_FACTOR_SETTING
+    public static final Setting<Double> NODE_BANDWIDTH_RECOVERY_OPERATOR_FACTOR_WRITE_SETTING = operatorFactorSetting(
+        "node.bandwidth.recovery.operator.factor.write"
     );
 
-    public static final Setting<Double> NODE_BANDWIDTH_RECOVERY_OPERATOR_FACTOR_READ_SETTING = factorSetting(
-        "node.bandwidth.recovery.operator.factor.read",
-        NODE_BANDWIDTH_RECOVERY_OPERATOR_FACTOR_SETTING
+    public static final Setting<Double> NODE_BANDWIDTH_RECOVERY_OPERATOR_FACTOR_READ_SETTING = operatorFactorSetting(
+        "node.bandwidth.recovery.operator.factor.read"
     );
 
     public static final Setting<Double> NODE_BANDWIDTH_RECOVERY_OPERATOR_FACTOR_MAX_OVERCOMMIT_SETTING = Setting.doubleSetting(
@@ -185,6 +183,14 @@ private static Setting<Double> operatorFactorSetting(String key, double defaultV
         }, Property.NodeScope, Property.OperatorDynamic);
     }
 
+    private static Setting<Double> operatorFactorSetting(String key) {
+        return new Setting<>(key, NODE_BANDWIDTH_RECOVERY_OPERATOR_FACTOR_SETTING, s -> Setting.parseDouble(s, 0d, 1d, key), v -> {
+            if (v == 0d) {
+                throw new IllegalArgumentException("Failed to validate value [" + v + "] for factor setting [" + key + "] must be > [0]");
+            }
+        }, Property.NodeScope, Property.OperatorDynamic);
+    }
+
     /**
      * User-defined factors have a value in (0.0, 1.0] and fall back to a corresponding operator factor setting.
      */