Skip to content

Conversation

@karawoo
Copy link
Member

@karawoo karawoo commented Jun 17, 2017

See #2164

This uses @inheritDotParams for some ... parameters. There are still some other places where we might be able to switch to @inheritDotParams.

There's an issue when the dot parameters come from another package and include links. For example the map_data function passes ... to maps::map(), but some of those params have links to other stuff within the maps package, and with @inheritDotParams the links get written to Rd as e.g. \link{county} when they need to be \link[maps:county]{county}

@karawoo
Copy link
Member Author

karawoo commented Jun 19, 2017

Per discussion this morning we won't use @inheritDotParams for functions from other packages for now. I'll go through again and see if there are more places we can use it, though.

@karawoo karawoo force-pushed the inheritDotParams branch from 99bc057 to f4ed5f7 Compare June 22, 2017 17:38
@karawoo karawoo requested a review from hadley June 22, 2017 17:47
@karawoo karawoo merged commit 0dab044 into tidyverse:master Jun 22, 2017
@karawoo karawoo deleted the inheritDotParams branch June 22, 2017 18:05
@lock
Copy link

lock bot commented Jan 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants