GitHub Desktop Pull Request Notification Testing - Failed Unit Tests #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tidy-dev
changed the title
Owner
Author
|
This is just a general pull request comment. Not a review comment. |
tidy-dev
commented
Oct 31, 2023
Comment on lines
-123
to
-148
| - name: Run script tests | ||
| if: matrix.arch == 'x64' | ||
| run: yarn test:script | ||
| - name: Install Windows code signing certificate | ||
| if: ${{ runner.os == 'Windows' }} | ||
| shell: bash | ||
| env: | ||
| CERT_CONTENTS: ${{ secrets.WINDOWS_CERT_PFX }} | ||
| run: base64 -d <<<"$CERT_CONTENTS" > ./script/windows-certificate.pfx | ||
| - name: Package production app | ||
| run: yarn package | ||
| env: | ||
| npm_config_arch: ${{ matrix.arch }} | ||
| WINDOWS_CERT_PASSWORD: ${{ secrets.WINDOWS_CERT_PASSWORD }} | ||
| - name: Upload artifacts | ||
| uses: actions/upload-artifact@v3 | ||
| if: ${{ inputs.upload-artifacts }} | ||
| with: | ||
| name: ${{matrix.friendlyName}}-${{matrix.arch}} | ||
| path: | | ||
| dist/GitHub Desktop-${{matrix.arch}}.zip | ||
| dist/GitHubDesktop-*.nupkg | ||
| dist/GitHubDesktopSetup-${{matrix.arch}}.exe | ||
| dist/GitHubDesktopSetup-${{matrix.arch}}.msi | ||
| dist/bundle-size.json | ||
| if-no-files-found: error |
Owner
Author
There was a problem hiding this comment.
Wow. Removing all kinds of stuff
tidy-dev
commented
Oct 31, 2023
Owner
Author
tidy-dev
left a comment
tidy-dev
left a comment
There was a problem hiding this comment.
This is a some general feedback that counts as a review comment!
tidy-dev
pushed a commit
that referenced
this pull request
Nov 19, 2024
Fully upgrading sass-loader pkg to the latest version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.