Skip to content

Conversation

@marcinciarka
Copy link

@marcinciarka marcinciarka commented May 8, 2023

Description

This fixes a minor problem probably introduced in #1062

Since we're making the hexId lowercase in the init action - we should do the same for the setChain action. Right now I'm trying to implement Optimism Goerli which is using 0x1A4 as an ID. This is getting converted to 0x1a4 internally and then compared to the response of eth_chainId which is in my case, sadly, 0x1A4 (and I can't change that).

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Docs Checklist

  • Include a screenshot of any changes (see docs README on running locally)
  • Add/update the appropriate package README (if applicable)
  • Add/update the related module in the docs demo (if applicable)
  • Add/update the related package in the docs/package.json file (if applicable)

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Tests with demo app (SDK)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

@vercel
Copy link

vercel bot commented May 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web3-onboard-docs ❌ Failed (Inspect) May 8, 2023 8:52pm

@marcinciarka marcinciarka changed the title Make chainIdHex case insensitive Fix: Make chainIdHex/id case insensitive in setChain May 8, 2023
@Adamj1232
Copy link
Contributor

@marcinciarka thank you for this PR! I ended up adding this change to a branch I was working and merged. Will close this PR but thank you for raising!

@Adamj1232 Adamj1232 closed this May 9, 2023
@marcinciarka
Copy link
Author

@Adamj1232 thats great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants