Skip to content

Conversation

@okxwallet
Copy link
Contributor

@okxwallet okxwallet commented Jan 18, 2023

Description

Checklist

  • The version field in package.json of the package you have made changes in is incremented following semantic versioning and using alpha release tagging
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • I have run yarn file-check, yarn type-check & yarn build to confirm there are not any associated errors
  • This PR passes the Circle CI checks

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Tests with demo app (SDK)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

@vercel
Copy link

vercel bot commented Jan 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
web3-onboard-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 27, 2023 at 9:10PM (UTC)

@Adamj1232
Copy link
Contributor

@okxwallet thank you for the PR and almost everything works well!
One issue is when the Custom network toggle is on the switching and adding chains does not work as expected - OKX Wallet - RPC Error: Unrecognized chain ID "0x1". Try adding the chain using wallet_addEthereumChain first. error is thrown.
This is after calling wallet_addEthereumChain with the standard chain data to add the chain.
I have added debugging logs in the code base for you to check when you have a moment.

@taylorjdawson
Copy link
Contributor

@okxwallet Hey just checking in here to see if you were able to resolve the issue raised by @Adamj1232?

Copy link
Contributor

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again @okxwallet for the collaboration and PR to support OKX's new wallet!
If interested in doing a bit of marketing on the new support please feel free to reach out 😃

@Adamj1232 Adamj1232 merged commit 9c693b6 into thirdweb-dev:v2-web3-onboard-develop Jan 27, 2023
Adamj1232 added a commit that referenced this pull request Jan 30, 2023
* feat: intergration of SafePal wallet (#1450)

* feat: intergration of SafePal wallet

* cleanup

Co-authored-by: Adam Carpenter <[email protected]>

* Update sdk version for TP (#1495)

* Trust wallet integration & SDK (#1463)

* feat: create trust wallet SDK

* docs: add Trust wallet SDK docs link

* docs: add trust SDK option

* docs:  add trust SDK option

* chore: add trust SDK jobs

* feat: add trust as part of the default wallets

* feat: add trust type

* fix: not identifying injected trust wallet

* fix: building error

* fix: only verify if trustwallet exists

* fix: wallets conflicting with each other

* chore: increment version

* chore: revert version

* docs: update documentation with Trust example

* docs: update description

Co-authored-by: Adam Carpenter <[email protected]>

* chore: update version

Co-authored-by: Adam Carpenter <[email protected]>

* docs: resolve typo

Co-authored-by: Adam Carpenter <[email protected]>

* fix: incorrectly checking providers

* Add trust to docs site

* Add docs and bump version

* Fix deploy config

---------

Co-authored-by: Adam Carpenter <[email protected]>

* Bump cookiejar from 2.1.3 to 2.1.4 (#1482)

Bumps [cookiejar](https://github.com/bmeck/node-cookiejar) from 2.1.3 to 2.1.4.
- [Release notes](https://github.com/bmeck/node-cookiejar/releases)
- [Commits](https://github.com/bmeck/node-cookiejar/commits)

---
updated-dependencies:
- dependency-name: cookiejar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump cookiejar from 2.1.3 to 2.1.4 in /examples/with-vite-react (#1483)

Bumps [cookiejar](https://github.com/bmeck/node-cookiejar) from 2.1.3 to 2.1.4.
- [Release notes](https://github.com/bmeck/node-cookiejar/releases)
- [Commits](https://github.com/bmeck/node-cookiejar/commits)

---
updated-dependencies:
- dependency-name: cookiejar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump cookiejar from 2.1.3 to 2.1.4 in /packages/demo (#1485)

Bumps [cookiejar](https://github.com/bmeck/node-cookiejar) from 2.1.3 to 2.1.4.
- [Release notes](https://github.com/bmeck/node-cookiejar/releases)
- [Commits](https://github.com/bmeck/node-cookiejar/commits)

---
updated-dependencies:
- dependency-name: cookiejar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump cookiejar from 2.1.3 to 2.1.4 in /docs (#1486)

Bumps [cookiejar](https://github.com/bmeck/node-cookiejar) from 2.1.3 to 2.1.4.
- [Release notes](https://github.com/bmeck/node-cookiejar/releases)
- [Commits](https://github.com/bmeck/node-cookiejar/commits)

---
updated-dependencies:
- dependency-name: cookiejar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump cookiejar from 2.1.3 to 2.1.4 in /examples/with-nextjs-13 (#1484)

Bumps [cookiejar](https://github.com/bmeck/node-cookiejar) from 2.1.3 to 2.1.4.
- [Release notes](https://github.com/bmeck/node-cookiejar/releases)
- [Commits](https://github.com/bmeck/node-cookiejar/commits)

---
updated-dependencies:
- dependency-name: cookiejar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Feat/add okx wallet (#1469)

* feature: add okx wallet to injected

* feature: add okx wallet to injected

* feature: add okx wallet to injected

* feature: add okx wallet to injected

* feature: add okx wallet to injected

* Update okx wallet usage

* Add debugging code for okx team

* Update svg for wallet

* Clean up logs

---------

Co-authored-by: Adam Carpenter <[email protected]>

* Update versions for release

* Address a couple of warnings from type-check

* Bump sdk version in core

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: QiAbc <[email protected]>
Co-authored-by: karim-yassine <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: okxwallet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants