From a7c34cecb1123028eef41a5b738e300a69e6f89d Mon Sep 17 00:00:00 2001 From: Adam Carpenter Date: Fri, 6 Jan 2023 12:40:07 -0700 Subject: [PATCH] Updated versioning for release and added new checklist to PR description --- package.json | 2 +- packages/core/package.json | 2 +- packages/demo/package.json | 6 +++--- packages/injected/package.json | 2 +- packages/ledger/package.json | 2 +- packages/react/package.json | 4 ++-- packages/vue/package.json | 4 ++-- pull_request_template.md | 20 +++++++++++++++++++- 8 files changed, 30 insertions(+), 12 deletions(-) diff --git a/package.json b/package.json index 94dc73a55..f27ac911c 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "web3-onboard-monorepo", - "version": "2.16.1", + "version": "2.17.0", "private": true, "workspaces": { "packages": [ diff --git a/packages/core/package.json b/packages/core/package.json index 2cfb18f38..042dc9493 100644 --- a/packages/core/package.json +++ b/packages/core/package.json @@ -1,6 +1,6 @@ { "name": "@web3-onboard/core", - "version": "2.13.0-alpha.1", + "version": "2.13.0", "description": "Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardized spec compliant web3 providers for all supported wallets, framework agnostic modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.", "keywords": [ "Ethereum", diff --git a/packages/demo/package.json b/packages/demo/package.json index 233985027..299d16a89 100644 --- a/packages/demo/package.json +++ b/packages/demo/package.json @@ -23,17 +23,17 @@ "webpack-dev-server": "4.7.4" }, "dependencies": { - "@web3-onboard/core": "^2.13.0-alpha.1", + "@web3-onboard/core": "^2.13.0", "@web3-onboard/coinbase": "^2.1.4", "@web3-onboard/transaction-preview": "^2.0.0", "@web3-onboard/dcent": "^2.2.2", "@web3-onboard/fortmatic": "^2.0.14", "@web3-onboard/gas": "^2.1.3", "@web3-onboard/gnosis": "^2.1.5", - "@web3-onboard/injected-wallets": "^2.5.0-alpha.2", + "@web3-onboard/injected-wallets": "^2.5.0", "@web3-onboard/keepkey": "^2.3.2", "@web3-onboard/keystone": "^2.3.2", - "@web3-onboard/ledger": "^2.4.0-alpha.1", + "@web3-onboard/ledger": "^2.4.0", "@web3-onboard/magic": "^2.1.3", "@web3-onboard/phantom": "^2.0.0-alpha.1", "@web3-onboard/portis": "^2.1.3", diff --git a/packages/injected/package.json b/packages/injected/package.json index b5bb18af1..1cc39483d 100644 --- a/packages/injected/package.json +++ b/packages/injected/package.json @@ -1,6 +1,6 @@ { "name": "@web3-onboard/injected-wallets", - "version": "2.5.0-alpha.2", + "version": "2.5.0", "description": "Injected wallet module for connecting browser extension and mobile wallets to Web3-Onboard. Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardised spec compliant web3 providers for all supported wallets, framework agnostic modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.", "keywords": [ "Ethereum", diff --git a/packages/ledger/package.json b/packages/ledger/package.json index f0da8e32d..76a3427df 100644 --- a/packages/ledger/package.json +++ b/packages/ledger/package.json @@ -1,6 +1,6 @@ { "name": "@web3-onboard/ledger", - "version": "2.4.0-alpha.1", + "version": "2.4.0", "description": "Ledger hardare wallet module for connecting to Web3-Onboard. Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardised spec compliant web3 providers for all supported wallets, framework agnostic modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.", "keywords": [ "Ethereum", diff --git a/packages/react/package.json b/packages/react/package.json index 9d6f55088..f491143c5 100644 --- a/packages/react/package.json +++ b/packages/react/package.json @@ -1,6 +1,6 @@ { "name": "@web3-onboard/react", - "version": "2.5.4-alpha.1", + "version": "2.5.4", "description": "A collection of React hooks for integrating Web3-Onboard in to React and Next.js projects. Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardised spec compliant web3 providers for all supported wallets, modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.", "keywords": [ "Ethereum", @@ -62,7 +62,7 @@ "typescript": "^4.5.5" }, "dependencies": { - "@web3-onboard/core": "^2.13.0-alpha.1", + "@web3-onboard/core": "^2.13.0", "@web3-onboard/common": "^2.2.3", "use-sync-external-store": "1.0.0" }, diff --git a/packages/vue/package.json b/packages/vue/package.json index 7fcd73d7d..369e1d219 100644 --- a/packages/vue/package.json +++ b/packages/vue/package.json @@ -1,6 +1,6 @@ { "name": "@web3-onboard/vue", - "version": "2.4.4-alpha.1", + "version": "2.4.4", "description": "A collection of Vue Composables for integrating Web3-Onboard in to a Vue or Nuxt project. Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardized spec compliant web3 providers for all supported wallets, modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.", "keywords": [ "Ethereum", @@ -63,7 +63,7 @@ "@vueuse/core": "^8.4.2", "@vueuse/rxjs": "^8.2.0", "@web3-onboard/common": "^2.2.3", - "@web3-onboard/core": "^2.13.0-alpha.1", + "@web3-onboard/core": "^2.13.0", "vue-demi": "^0.12.4" }, "peerDependencies": { diff --git a/pull_request_template.md b/pull_request_template.md index f377d50be..12e7a57fb 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -2,8 +2,26 @@ ### Checklist -- [ ] The version field in `package.json` is incremented following [semantic versioning](https://semver.org/) +- [ ] The version field in `package.json` of the package you have made changes in is incremented following [semantic versioning](https://semver.org/) and using alpha release tagging - [ ] The box that allows repo maintainers to update this PR is checked - [ ] I tested locally to make sure this feature/fix works - [ ] I have run `yarn file-check`, `yarn type-check` & `yarn build` to confirm there are not any associated errors - [ ] This PR passes the Circle CI checks + +### If this PR includes changes to add an injected wallet or SDK wallet module: +Please complete the following using the internal demo package. +To run this demo use the command `yarn && yarn dev` to get the project running at `http://localhost:8080/` + +#### Tests with demo app (injected) +- [ ] send transaction +- [ ] switch chains +- [ ] sign message +- [ ] sign typed message +- [ ] disconnect + +#### Tests with demo app (SDK) +- [ ] send transaction +- [ ] switch chains +- [ ] sign message +- [ ] sign typed message +- [ ] disconnect \ No newline at end of file