-
Notifications
You must be signed in to change notification settings - Fork 541
[core-v2.13.0-alpha.1]: Feature - Add Unstoppable Domains Reverse Resolution #1410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Adamj1232
merged 9 commits into
thirdweb-dev:v2-web3-onboard-develop
from
V-Shadbolt:feature/unstoppable-reverse-resolution
Jan 4, 2023
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
35aaf1d
added UD resolution dependency
V-Shadbolt bf66fbd
renames shortenEns to domain agnostic
V-Shadbolt d1e0be0
Merge branch 'v2-web3-onboard-develop' into feature/unstoppable-rever…
V-Shadbolt 7365aca
added uns reverse resolution
V-Shadbolt a40b761
removed excess console log
V-Shadbolt 06c7730
Merge branch 'v2-web3-onboard-develop' into feature/unstoppable-rever…
V-Shadbolt 871f4f5
Merge remote-tracking branch 'upstream/v2-web3-onboard-develop' into …
Adamj1232 bc5c916
Bump core version and add alpha tag, but react and vuew versions, pre…
Adamj1232 affa6e2
Fix demo
Adamj1232 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@V-Shadbolt quick question here, can you provide a little background on the reason for this?
Also, can it be scoped to the ustoppabledomains package?
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Adamj1232 Yup! This was added because rollup wasn't including the unstoppable domains node module when compiling which threw a bunch of errors when the functions were called.
The commonjs plugin instructs rollup to convert node modules to ES6 so that they can be interpreted by browsers and the
include: /node_modules/flag is for the directory of the modules to include during compilationI don't believe this can be scoped back unless we can specify just the unstoppable module with something like this:
include: /node_modules/@unstoppabledomains/.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah gotcha, thank you for the fast response!
include: /node_modules/@unstoppabledomains/is what I had in mind.I can open a PR or you can but want to get your teams approval on the changes 🤓
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Managed to get it rescoped to just Unstoppable using the below snippet while retaining the original functionality of this PR.
commonjs({ namedExports: { '../../node_modules/@unstoppabledomains/resolution/build/index.js': [ 'Resolution' ] }, }),There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR opened to fix this issue: #1476