[trezor-v2.2.2-alpha.1] : Bug - Fix trezor signing issue by adding a new transaction type #1246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnbc1QWFyb24
reviewed
Sep 1, 2022
| - [ ] The box that allows repo maintainers to update this PR is checked | ||
| - [ ] I tested locally to make sure this feature/fix works | ||
| - [ ] I have run `yarn type-check` & `yarn build` to confirm there are not any associated errors | ||
| - [ ] I have run `yarn check` & `yarn build` to confirm there are not any associated errors |
Contributor
There was a problem hiding this comment.
Is it not yarn type-check to check the types across the repo?
Contributor
Author
There was a problem hiding this comment.
@aaronbarnardsound looks like it was updated recently from this PR #1199
I updated here since it took me a while to figure out why yarn type-check wasn't working
lnbc1QWFyb24
approved these changes
Sep 1, 2022
Contributor
lnbc1QWFyb24
left a comment
lnbc1QWFyb24
left a comment
There was a problem hiding this comment.
Approved, just one question on the pull request template change.
This was referenced Sep 6, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix Trezor signing issue by adding a new transaction type used by ethers in signing
Trezor Connect builds a different signed receipt for type2 transactions so adding handling for that type of transaction was required using the method
FeeMarketEIP1559Transaction.fromTxData(....)Also bumped Trezor-Connect version and some minor cleanup
Checklist
package.jsonis incremented following semantic versioningyarn type-check&yarn buildto confirm there are not any associated errors