From 55a7c90e2c79c0623e81b9f9be29c0b9fbfb80d3 Mon Sep 17 00:00:00 2001 From: Aaron Barnard Date: Fri, 12 Aug 2022 13:30:48 +1000 Subject: [PATCH 1/2] Move re-init check to top of init --- packages/core/src/index.ts | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/packages/core/src/index.ts b/packages/core/src/index.ts index 8a765daa7..1c021d3d8 100644 --- a/packages/core/src/index.ts +++ b/packages/core/src/index.ts @@ -92,9 +92,16 @@ function init(options: InitOptions): OnboardAPI { connect } = options + const { device, svelteInstance } = configuration + + if (svelteInstance) { + // if already initialized, need to cleanup old instance + console.warn('Re-initializing Onboard and resetting back to initial state') + reset$.next() + } + initI18N(i18n) addChains(chainIdToHex(chains)) - const { device, svelteInstance } = configuration if (typeof connect !== undefined) { updateConnectModal(connect) @@ -193,12 +200,6 @@ function init(options: InitOptions): OnboardAPI { updateNotify(notifyUpdate) } - if (svelteInstance) { - // if already initialized, need to cleanup old instance - console.warn('Re-initializing Onboard and resetting back to initial state') - reset$.next() - } - const app = svelteInstance || mountApp() updateConfiguration({ From 472f825a1b2a1b76e093ed622c1f3efaf7958461 Mon Sep 17 00:00:00 2001 From: Aaron Barnard Date: Fri, 12 Aug 2022 13:32:12 +1000 Subject: [PATCH 2/2] Increment versions --- packages/core/package.json | 2 +- packages/react/package.json | 4 ++-- packages/vue/package.json | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/core/package.json b/packages/core/package.json index cfdd4438f..b38964060 100644 --- a/packages/core/package.json +++ b/packages/core/package.json @@ -1,6 +1,6 @@ { "name": "@web3-onboard/core", - "version": "2.7.0-alpha.4", + "version": "2.7.0-alpha.5", "description": "Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardized spec compliant web3 providers for all supported wallets, framework agnostic modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.", "keywords": [ "Ethereum", diff --git a/packages/react/package.json b/packages/react/package.json index ed7ec3290..b1f4c1247 100644 --- a/packages/react/package.json +++ b/packages/react/package.json @@ -1,6 +1,6 @@ { "name": "@web3-onboard/react", - "version": "2.2.6-alpha.2", + "version": "2.2.6-alpha.3", "description": "A collection of React hooks for integrating Web3-Onboard in to React and Next.js projects. Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardised spec compliant web3 providers for all supported wallets, modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.", "keywords": [ "Ethereum", @@ -62,7 +62,7 @@ "typescript": "^4.5.5" }, "dependencies": { - "@web3-onboard/core": "^2.7.0-alpha.4", + "@web3-onboard/core": "^2.7.0-alpha.5", "@web3-onboard/common": "^2.1.8-alpha.1", "use-sync-external-store": "1.0.0" }, diff --git a/packages/vue/package.json b/packages/vue/package.json index 0ace33408..1a314c99f 100644 --- a/packages/vue/package.json +++ b/packages/vue/package.json @@ -1,6 +1,6 @@ { "name": "@web3-onboard/vue", - "version": "2.1.6-alpha.2", + "version": "2.1.6-alpha.3", "description": "A collection of Vue Composables for integrating Web3-Onboard in to a Vue or Nuxt project. Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardised spec compliant web3 providers for all supported wallets, modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.", "keywords": [ "Ethereum", @@ -63,7 +63,7 @@ "@vueuse/core": "^8.4.2", "@vueuse/rxjs": "^8.2.0", "@web3-onboard/common": "^2.1.8-alpha.1", - "@web3-onboard/core": "^2.7.0-alpha.4", + "@web3-onboard/core": "^2.7.0-alpha.5", "vue-demi": "^0.12.4" }, "peerDependencies": {