From fa363402a08629cf9b241c92947b934a14128230 Mon Sep 17 00:00:00 2001 From: Taylor Dawson Date: Mon, 1 Aug 2022 11:47:38 -0700 Subject: [PATCH 1/7] Adds status checks to PR --- .github/workflows/pr-status-checks.yml | 32 ++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 .github/workflows/pr-status-checks.yml diff --git a/.github/workflows/pr-status-checks.yml b/.github/workflows/pr-status-checks.yml new file mode 100644 index 000000000..1952b9274 --- /dev/null +++ b/.github/workflows/pr-status-checks.yml @@ -0,0 +1,32 @@ +name: PR Status Checks + +on: + # Allows it to be manually triggered, used primarily for debugging + workflow_dispatch: + pull_request: + branches: + - v2-web3-onboard-develop + +jobs: + checks: + name: "Checks" + runs-on: ubuntu-latest + + steps: + - name: Checkout code + uses: actions/checkout@v2 + + - name: Setup Nodejs and yarn + uses: actions/setup-node@v2 + with: + node-version: "16" + cache: yarn + + - name: Install dependencies + run: yarn install --immutable + + - name: Check formatting + run: yarn type-check + + - name: Check that it builds + run: yarn build \ No newline at end of file From 470f2b5dbb071d85250cbad6072cfe2f241cd815 Mon Sep 17 00:00:00 2001 From: Taylor Dawson Date: Wed, 31 Aug 2022 22:27:02 -0700 Subject: [PATCH 2/7] build then check + change script name --- .github/workflows/pr-status-checks.yml | 8 ++++---- package.json | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/pr-status-checks.yml b/.github/workflows/pr-status-checks.yml index 1952b9274..8302e74c1 100644 --- a/.github/workflows/pr-status-checks.yml +++ b/.github/workflows/pr-status-checks.yml @@ -25,8 +25,8 @@ jobs: - name: Install dependencies run: yarn install --immutable - - name: Check formatting - run: yarn type-check - - name: Check that it builds - run: yarn build \ No newline at end of file + run: yarn build + + - name: Check formatting and types + run: yarn check diff --git a/package.json b/package.json index c93ada7c7..7deea615b 100644 --- a/package.json +++ b/package.json @@ -51,7 +51,7 @@ "format": "prettier --write 'packages/**/*.ts'", "dev": "yarn wsrun dev", "build": "yarn wsrun --serial build", - "type-check": "yarn wsrun type-check" + "check": "yarn wsrun type-check" }, "devDependencies": { "prettier": "^2.4.1", From 6ff5ec7d9ecd5fdf92d04a75ce4ac312709fd919 Mon Sep 17 00:00:00 2001 From: Taylor Dawson Date: Wed, 31 Aug 2022 22:49:54 -0700 Subject: [PATCH 3/7] remove immutable --- .github/workflows/pr-status-checks.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-status-checks.yml b/.github/workflows/pr-status-checks.yml index 8302e74c1..deafb6fe8 100644 --- a/.github/workflows/pr-status-checks.yml +++ b/.github/workflows/pr-status-checks.yml @@ -23,8 +23,8 @@ jobs: cache: yarn - name: Install dependencies - run: yarn install --immutable - + run: yarn + - name: Check that it builds run: yarn build From 2e31121ea0012adc13df7d95a2bdbad8e24ccfbb Mon Sep 17 00:00:00 2001 From: Taylor Dawson Date: Thu, 1 Sep 2022 00:18:33 -0700 Subject: [PATCH 4/7] Add nohoist --- package.json | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/package.json b/package.json index 7deea615b..61fd32181 100644 --- a/package.json +++ b/package.json @@ -2,14 +2,15 @@ "name": "web3-onboard-monorepo", "version": "2.9.0", "private": true, - "workspaces": [ - "./packages/*" - ], + "workspaces": { + "packages": ["./packages/*"], + "nohoist": ["**/react", "**/react-dom"] + }, "description": "Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardised spec compliant web3 providers for all supported wallets, framework agnostic modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.", "keywords": [ "Ethereum", "Web3", - "EVM", + "EVM",x "dapp", "Multichain", "Wallet", From 9b7c547ae745ef2c5e1c9ba8ea47ec465e958880 Mon Sep 17 00:00:00 2001 From: Taylor Dawson Date: Thu, 1 Sep 2022 00:19:36 -0700 Subject: [PATCH 5/7] fix package.json --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 61fd32181..6c711abb3 100644 --- a/package.json +++ b/package.json @@ -10,7 +10,7 @@ "keywords": [ "Ethereum", "Web3", - "EVM",x + "EVM", "dapp", "Multichain", "Wallet", From 78da2feb8738b54ad7fb6ea0c014ea00e6ebae72 Mon Sep 17 00:00:00 2001 From: Taylor Dawson Date: Thu, 1 Sep 2022 00:27:06 -0700 Subject: [PATCH 6/7] add last nohoist pkg --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 6c711abb3..58dbb5f17 100644 --- a/package.json +++ b/package.json @@ -4,7 +4,7 @@ "private": true, "workspaces": { "packages": ["./packages/*"], - "nohoist": ["**/react", "**/react-dom"] + "nohoist": ["**/react", "**/react-dom", "csstype"] }, "description": "Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardised spec compliant web3 providers for all supported wallets, framework agnostic modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.", "keywords": [ From c99c5da0d50912c1e86a28ee50bd479bc999e2e4 Mon Sep 17 00:00:00 2001 From: Taylor Dawson Date: Thu, 1 Sep 2022 00:34:43 -0700 Subject: [PATCH 7/7] ammend pkg path --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 58dbb5f17..bb14e7f2b 100644 --- a/package.json +++ b/package.json @@ -4,7 +4,7 @@ "private": true, "workspaces": { "packages": ["./packages/*"], - "nohoist": ["**/react", "**/react-dom", "csstype"] + "nohoist": ["**/react", "**/react-dom", "**/csstype"] }, "description": "Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardised spec compliant web3 providers for all supported wallets, framework agnostic modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.", "keywords": [