Skip to content

Conversation

@mahmud-bn
Copy link
Contributor

Description

Adds an example folder with a Next.js project that implements a basic @web3-onboard/ledger support

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • I have run yarn type-check & yarn build to confirm there are not any associated errors
  • This PR passes the Circle CI checks

@mahmud-bn mahmud-bn requested a review from Adamj1232 August 2, 2022 22:00
@mahmud-bn mahmud-bn requested a review from Adamj1232 August 2, 2022 23:02
Copy link
Contributor

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, might have some fun adding some styles/BN logos to the landing page if you want 🤓

@mahmud-bn
Copy link
Contributor Author

Overall looks good, might have some fun adding some styles/BN logos to the landing page if you want 🤓

I'm not sure we want that across all examples including prettier. I would assume we already have a fancy React Demo for that. What we want, I think, is a set of examples that can be easily forked.
E.g
https://github.com/wagmi-dev/wagmi/tree/main/examples/next
https://github.com/Uniswap/web3-react/tree/main/packages/example-next

@mahmud-bn mahmud-bn merged commit 6e0d1a9 into v2-web3-onboard-develop Aug 3, 2022
@lnbc1QWFyb24 lnbc1QWFyb24 mentioned this pull request Aug 12, 2022
@Adamj1232 Adamj1232 deleted the examples/with-ledger branch January 26, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants