[common-v2.1.7-alpha.5, core-v2.6.0-alpha.8, react-v2.2.5-alpha.7]fix: weifix

[mahmud-bn]

Description

This PR:

• enforces the weiToETH function to accept only strings from core and common
• returns ethers.BigNumber for GetInterfaceHelpers used by Ledger

Checklist

• The version field in package.json is incremented following semantic versioning
• The box that allows repo maintainers to update this PR is checked
• I tested locally to make sure this feature/fix works
• I have run yarn type-check & yarn build to confirm there are not any associated errors
• This PR passes the Circle CI checks

[lnbc1QWFyb24]

Any reason to change this validation?

[mahmud-bn]

This was related to the validation error fix for hardware wallets chain added to the main release:

There is another Joi.alternatives- string or number validation included in the previous PR core chainID which .

I guess placing chains: Chain[] | ChainWithDecimalId[] will allow for such validation but I'm not sure that's needed since the GetInterfaceHelpers used by Ledger works with the internal hex string.

[Adamj1232]

This seem correct if we are using Hex chain IDs internally(converting number chain ids to hex after initialization) it doesn't seem we would need positive number validation within the common package although I may be misunderstanding the possible flows of potential chainId

[lnbc1QWFyb24]

Do we also need to remove the bignumber.js dep from core and the rollup externals since it is not being used anymore?

[mahmud-bn]

Do we also need to remove the bignumber.js dep from core and the rollup externals since it is not being used anymore?

It's still used by preflight-notifications.ts and notify.ts