Skip to content

[injected-v2.0.15-alpha.2] : Fix - Updated Binance Wallet provider patch #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2022
Merged

[injected-v2.0.15-alpha.2] : Fix - Updated Binance Wallet provider patch #1174

merged 1 commit into from
Jul 27, 2022

Conversation

@Adamj1232
Copy link
Contributor

@Adamj1232 Adamj1232 commented Jul 27, 2022 •
edited
Loading

Description

  • Updated Binance Wallet provider patch as their current injected provider is now READONLY which was causing issues with adding event listeners and properties to the window.BinanceChain object
  • Removed unnecessary patches with current provider
  • Also updated some typing to remove warnings for parseInt params

Fixes #1169 @ReflectiveChimp

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • I have run yarn type-check & yarn build to confirm there are not any associated errors
  • This PR passes the Circle CI checks

@Adamj1232 Adamj1232 mentioned this pull request Jul 27, 2022
Closed
1 task
@Adamj1232 Adamj1232 merged commit 1b3fc9e into v2-web3-onboard-develop Jul 27, 2022
@Adamj1232 Adamj1232 deleted the fix/binance_wallet_provider branch July 27, 2022 17:39
This was referenced Jul 27, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@taylorjdawson taylorjdawson taylorjdawson approved these changes

@mahmud-bn mahmud-bn mahmud-bn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Binance Wallet (injected) broken as of 2.13.1

4 participants

@Adamj1232 @taylorjdawson @mahmud-bn