Skip to content

Conversation

@Adamj1232
Copy link
Contributor

@Adamj1232 Adamj1232 commented Jul 25, 2022

Description

Fixes: #1156
Add optionality to containerElement property within the accountCenter init object
Format validation so Account Center validations are close to each other and the Account Center init object use the same reference object called accountCenterInitOptions within the validation file
Bump versions

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • I have run yarn type-check & yarn build to confirm there are not any associated errors
  • This PR passes the Circle CI checks

@Adamj1232 Adamj1232 requested a review from mahmud-bn July 25, 2022 17:01
@Adamj1232 Adamj1232 changed the title Add optionality to containerElement, format validation so accountCent… [core-v2.6.0-alpha.3, react-v2.2.5-alpha.2, vue-v2.1.5-alpha.2] : Fix - Add optionality to containerElement, format validation so accountCent… Jul 25, 2022
@Adamj1232 Adamj1232 changed the title [core-v2.6.0-alpha.3, react-v2.2.5-alpha.2, vue-v2.1.5-alpha.2] : Fix - Add optionality to containerElement, format validation so accountCent… [core-v2.6.0-alpha.4, react-v2.2.5-alpha.2, vue-v2.1.5-alpha.2] : Fix - Add optionality to containerElement, format validation so accountCent… Jul 25, 2022
@Adamj1232 Adamj1232 changed the title [core-v2.6.0-alpha.4, react-v2.2.5-alpha.2, vue-v2.1.5-alpha.2] : Fix - Add optionality to containerElement, format validation so accountCent… [core-v2.6.0-alpha.4, react-v2.2.5-alpha.4, vue-v2.1.5-alpha.4] : Fix - Add optionality to containerElement, format validation so accountCent… Jul 25, 2022
@Adamj1232 Adamj1232 merged commit fb81fbb into v2-web3-onboard-develop Jul 25, 2022
@Adamj1232 Adamj1232 deleted the fix/accountCenter_containerElement branch July 25, 2022 18:38
This was referenced Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Account Center Options cannot be specified

3 participants