Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves an issue were we pass a nonce missing 0x prefix.
To get the transaction signed on line 404 in trezor/src/index.ts we call
Transaction.fromTxData. TheTransactionclass is coming from@ethereumjs/tx.When calling
fromTxDatathat package will instantiate a class extending theirBaseTransaction. TheBaseTransactionconstructor will try to convert thenonceto first abufferand thenBigIntsee here . To convert the string to a buffer they rely ontoBufferfrom@ethereumjs/util, this method will throw if passed a string not prefixed with0xSee hereUsing an infura provider I consistently got a nonce without
0x. I also fixed some minor type errors.Checklist
package.jsonis incremented following semantic versioningyarn type-check&yarn buildto confirm there are not any associated errors