feat: core injected wallet support #1160
Conversation
|
Thanks for this @itsmnthn. We will review this and get it merged. |
… injected package.json
|
@itsmnthn does this PR work on your end? I am not able to get it to work from your fork |
itsmnthn
force-pushed
the
v2-web3-onboard-develop
branch
from
8757a5a to
9ea201c
Compare
| !!provider && !!provider[ProviderIdentityFlag.Core], | ||
| getIcon: async () => (await import('./icons/core.js')).default, | ||
| getInterface: async () => ({ | ||
| provider: createEIP1193Provider(window.avalanche) |
There was a problem hiding this comment.
@itsmnthn there will need to be more work done around this provider as it does not follow the 1193 standard
Upon approving a a site the provider doesnt send the proper response is one problem I see initially
There was a problem hiding this comment.
I faced the same problem it happens one time initially. But I think it will be fixed since they are still developing. But I'll ask devs about this and other issues I faced in terms of UX. Hope to get it fixed soon.
I've tried adding custom wallet when initializing onboard check this project https://github.com/itsmnthn/nuxt3-web3-onboard-mvp |
|
@itsmnthn we have reached out to AvaLabs to get the issues with the wallet provider resolved |
|
Closing as Core wallet support has been merged with #1259 and is available with injected-wallet package version 2.2.2-alpha.1 |
3 participants
Description
Adding Core(Avalanche Core) wallet support in inject wallet
Checklist
package.jsonis incremented following semantic versioningyarn type-check&yarn buildto confirm there are not any associated errors