Skip to content

Conversation

@mahmud-bn
Copy link
Contributor

@mahmud-bn mahmud-bn commented Jul 10, 2022

Description

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • This PR passes the Circle CI checks

@mahmud-bn mahmud-bn changed the title [core-v]: Enhancement - Convert Wei to Eth [common-v2.1.7-alpha.1, core-v2.6.0-alpha.1, react-v2.2.5-alpha.1, vue-2.1.5-alpha.1, demo-v2.0.6]: Enhancement - Convert Wei to Eth Jul 15, 2022
@mahmud-bn mahmud-bn requested a review from lnbc1QWFyb24 July 22, 2022 17:54
Copy link
Contributor

@taylorjdawson taylorjdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few suggestions

@mahmud-bn mahmud-bn merged commit af5a09f into v2-web3-onboard-develop Jul 28, 2022
@Adamj1232 Adamj1232 mentioned this pull request Jul 28, 2022
5 tasks
@Adamj1232 Adamj1232 deleted the enhancement/weitoeth-format branch January 26, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants