Skip to content

Conversation

@benjaminreid
Copy link
Contributor

@benjaminreid benjaminreid commented Jun 29, 2022

Description

Fixes #1105, a typeof check which was evaluating to true even when notify would be undefined.

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • This PR passes the Circle CI checks

Copy link
Contributor

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@Adamj1232 Adamj1232 merged commit a9e267f into thirdweb-dev:v2-web3-onboard-develop Jun 29, 2022
@benjaminreid benjaminreid deleted the issue-1105 branch June 30, 2022 08:55
This was referenced Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NextJS: TypeError: Cannot use 'in' operator to search for 'desktop' in undefined

2 participants