feat: intergration of Rabby wallet #1069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylorjdawson
suggested changes
Jun 15, 2022
Contributor
taylorjdawson
left a comment
taylorjdawson
left a comment
There was a problem hiding this comment.
@vvvvvv1vvvvvv A few comments but looks good, thanks for the contribution!
Co-authored-by: Taylor Dawson <[email protected]>
Co-authored-by: Taylor Dawson <[email protected]>
Co-authored-by: Taylor Dawson <[email protected]>
Contributor
Author
|
@taylorjdawson all suggestions fixed |
Contributor
|
Thanks @vvvvvv1vvvvvv this looks good. We'll get this merged and released later this week. |
Adamj1232
reviewed
Jun 28, 2022
Contributor
|
@vvvvvv1vvvvvv we had a recent release so there is a conflict and a note to update the version otherwise I can get this merged as soon as this is completed |
Contributor
Author
conflict resolved |
Co-authored-by: Adam Carpenter <[email protected]>
Adamj1232
approved these changes
Jun 29, 2022
Contributor
Adamj1232
left a comment
Adamj1232
left a comment
There was a problem hiding this comment.
Nice, thank you for the PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add intergration of Rabby wallet, Rabby will add into the list if user installed Rabby
More about Rabby wallet: https://rabby.io/
Checklist
package.jsonis incremented following semantic versioning