[core - v2.2.12-alpha.2] : bug - Add lowercase coercion to chain ids, add Optimism test net mapped to Optimism Icon #1062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylorjdawson
approved these changes
Jun 14, 2022
mahmud-bn
approved these changes
Jun 14, 2022
Merged
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue #1061
Add Optimism test net mapped to Optimism Icon
0x45Add lowercase coercion to chain ids on setting of chains in store.
This will handle situations similar to one seen with optimism where the chain Id set was
0xAwhile the associated icon was0xacausing an issue where the icon couldn't be found and a warning icon was displayed.Checklist
package.jsonis incremented following semantic versioning