[fix] fix connect wallet with disableModal flag #1033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
#1032 - related to an issue |
Contributor
Author
|
@Adamj1232 @mahmud-bn @taylorjdawson please review PR. |
YugasVasyl
approved these changes
Jun 1, 2022
applicature-dlitvinov
force-pushed
the
v2-web3-onboard-develop-custom-connect-modal
branch
from
3385939 to
2382320
Compare
Adamj1232
suggested changes
Jun 6, 2022
applicature-dlitvinov
force-pushed
the
v2-web3-onboard-develop-custom-connect-modal
branch
from
bebf2ed to
380969c
Compare
Contributor
Author
|
@Adamj1232 fixed all comments. Pls, review again. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set inProgress to false if connection error.
Fix for #1032
Checklist
package.jsonis incremented following semantic versioning