Skip to content

Conversation

@applicature-dlitvinov
Copy link
Contributor

@applicature-dlitvinov applicature-dlitvinov commented May 31, 2022

Description

Added providerConnectionInfo to the Chain model. It helps to create providers with authorization parameters.

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • This PR passes the Circle CI checks

@applicature-dlitvinov applicature-dlitvinov changed the title feature: Add ability to create StaticJsonRpcProvider with ConnectionInfo feature(#1030): Add ability to create StaticJsonRpcProvider with ConnectionInfo May 31, 2022
@applicature-dlitvinov
Copy link
Contributor Author

#1030 - related to an isuue.

@applicature-dlitvinov
Copy link
Contributor Author

@Adamj1232 @mahmud-bn @taylorjdawson please review PR.

@applicature-dlitvinov applicature-dlitvinov force-pushed the v2-web3-onboard-develop branch 2 times, most recently from b348e8d to ce2eb49 Compare June 7, 2022 10:31
@applicature-dlitvinov
Copy link
Contributor Author

@Adamj1232 Could you please review it?

@applicature-dlitvinov applicature-dlitvinov force-pushed the v2-web3-onboard-develop branch 2 times, most recently from 0047227 to a2ce9a9 Compare June 7, 2022 16:06
@taylorjdawson
Copy link
Contributor

@applicature-dlitvinov Hey thanks for contributing! We'll take a look at this and get back to you 🙌

Copy link
Contributor

@taylorjdawson taylorjdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple comments! Also could you provide an example of how you would use this? Thanks!

@applicature-dlitvinov
Copy link
Contributor Author

@taylorjdawson
Sometimes we need to use a private network RPC URL with some credentials, It's more secure and more stable than native RPC (Sometimes has crashes or lags).

const onboard = Onboard({
      wallets: [injected],
      chains: [
        {
          id: '0x61',
          token: 'BNB',
          label: 'Binance Testnet',
          rpcUrl: `${CUCTOM_BSC_PRC}`,
          providerConnectionInfo: {
            url: `${CUCTOM_BSC_PRC}`,
            user: `${LOGIN}`,
            password: `${PASSWORD}`
          }
        },
        ...
      ]
    })

@applicature-dlitvinov
Copy link
Contributor Author

@taylorjdawson Coul. you please review again

@lnbc1QWFyb24 lnbc1QWFyb24 merged commit c809026 into thirdweb-dev:v2-web3-onboard-develop Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants