Feature: optional public RPC and block explorer Chain params

[katspaugh]

Description

Resolves #1020 and #948.

As outlined in #1020, it's sometimes necessary to pass a custom (typically public) RPC when adding a new chain to the user's wallet.

Checklist

• The version field in package.json is incremented following semantic versioning
• The box that allows repo maintainers to update this PR is checked
• I tested locally to make sure this feature/fix works
• This PR passes the Circle CI checks

[katspaugh]

@aaronbarnardsound @Adamj1232 @taylorjdawson gm! Any feedback for this?

[lnbc1QWFyb24]

Thanks for this PR @katspaugh. Another approach that I think might be more clear naming wise, is to add an optional publicRpcUrl parameter to the Chain object and use that in the add chain method. That way the Chain info can be set in one place and then there's no need to think about it when setting the chain. I also think it will help distinguish between the two rpcUrl parameters. What do you think?

[lnbc1QWFyb24]

Just adding a note @taylorjdawson while we are here we should also add an option blockExplorerUrl parameter as requested in #948

[katspaugh]

Makes sense!

I'll update the PR to extend the Chain object then 👍

[taylorjdawson]

Hey @katspaugh! I see some commits here, is this ready for re-review?

[katspaugh]

I haven't fully tested this version yet but a review would be appreciated, yes!

[taylorjdawson]

@katspaugh This looks good! Have you had a chance to test?

[katspaugh]

Still wrapping my head around testing monorepos, I'll get back to you on the weekend!

[taylorjdawson]

@katspaugh I can also test if you want, was there anything else you wanted to add to the PR?

[katspaugh]

Oh, that'd be awesome. Let me just fix those git conflicts in the package.json's.

[mahmud-bn]

Hi @katspaugh
Thanks for creating the PR. This has been merged

[katspaugh]

Amazing, thank you guys!