Update the react peerdep to not peg to React 17 #1009
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package is currently pegged by peer dependency to React 17, which is likely to be the least adopted React version in a while, given that it was a glorified minor version before React 18. This peer dep should be more than fine for what this package does, and just increases compatibility without causing problems for users that are now able to use the package where they wouldn't be allowed to before.
Author
|
Not needed now that #915 is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package is currently pegged by peer dependency to React 17, which is likely to be the least adopted React version in a while, given that it was a glorified minor version before React 18. This peer dep should be more than fine for what this package does, and just increases compatibility without causing problems for users that are now able to use the package where they wouldn't be allowed to before.
Currently this package should be compatible with React 16, 17, and 18. But the Peer Deps listed basically disallow you from having any react packages that aren't in V17, which is almost certainly not the desired behavior, and a pretty annoying consequence of using the package currently. There's another PR (#915) that upgrades to React 18, but that isn't necessarily as compatible as this change and should be a lot easier to get through.
Description
Checklist
package.jsonis incremented following semantic versioning