Skip to content

Conversation

@Adamj1232
Copy link
Contributor

@Adamj1232 Adamj1232 commented May 13, 2022

Description

After working with the develop flow on this branch it seemed like the best way to help development move forward was to revert the internal tagged -alpha.x package versions thus returning packages to parity with the stable released versions.
The need for publishing alpha branches was to allow for progress within the staging env for the react project. Those releases have been published and tagged as NEXT so we are able to revert the versions in the develop branch for better clarity and development going forward.
Couple things to note

  • The stable and next versions published are all equal in code progress/feature development
  • From here when a change is made on a feature branch cut from v2-web3-onboard-develop in the package.json the version will be incremented as required by the change (major | minor | patch) and the -alpha.x tag will be added to the version
  • After PR approval and testing the feature branch will be merged back into v2-web3-onboard-develop for testing in the staging env : this can be done by rerunning the CircleCI job for the ReactDemo or running yarn setup-staging
  • Once tested and ready for release a release branch will be cut for the v2-web3-onboard-develop branch
  • This release branch will have the -alpha.x tags removed leaving a incremented version from the latest stable/release branch
  • The release branch will be merged into both v2-web3-onboard(causing a publish of the latest version as stable) and the v2-web3-onboard-develop branch causing no publish to occur but bringing parity between the two branches

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • This PR passes the Circle CI checks

@Adamj1232 Adamj1232 merged commit b63b141 into v2-web3-onboard-develop May 13, 2022
@Adamj1232 Adamj1232 deleted the update/revert_alpha_tags branch May 13, 2022 21:37
tokensex pushed a commit to tokensex/web3-onboard that referenced this pull request May 30, 2022
…ble release (thirdweb-dev#1001)

* Revert internal alpha packages versions
* Cleanup yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants