Skip to content

Commit ed5456d

Browse files
authored
Merge pull request #1328 from blocknative/docs-develop
Docs release
2 parents add8681 + f069af5 commit ed5456d

File tree

4 files changed

+56
-28
lines changed

4 files changed

+56
-28
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ If you're coming from v1, we've created a [migration guide for you](https://docs
7575

7676
## Documentation
7777

78-
For full documentation, check out the README.md for each package:
78+
For full documentation, check out the README.md for each package or the [docs page here](https://onboard.blocknative.com/docs/overview/introduction#features):
7979

8080
**Core Repo**
8181

docs/README.md

Lines changed: 13 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,38 +1,25 @@
1-
# create-svelte
1+
# Docs
22

3-
Everything you need to build a Svelte project, powered by [`create-svelte`](https://github.com/sveltejs/kit/tree/master/packages/create-svelte).
3+
## Prereqs
44

5-
## Creating a project
5+
Install [yarn](https://classic.yarnpkg.com/en/docs/install)
66

7-
If you're seeing this, you've probably already done this step. Congrats!
7+
## Running docs server locally
88

9-
```bash
10-
# create a new project in the current directory
11-
npm init svelte
9+
Run the following command within the `docs/` folder
1210

13-
# create a new project in my-app
14-
npm init svelte my-app
11+
```sh
12+
yarn && yarn dev
1513
```
1614

17-
## Developing
15+
The server should start on [localhost:3000](http://localhost:3000/).
1816

19-
Once you've created a project and installed dependencies with `npm install` (or `pnpm install` or `yarn`), start a development server:
17+
## Contributing
2018

21-
```bash
22-
npm run dev
19+
Confirm changes look as expected on local instance.
2320

24-
# or start the server and open the app in a new browser tab
25-
npm run dev -- --open
26-
```
27-
28-
## Building
29-
30-
To create a production version of your app:
31-
32-
```bash
33-
npm run build
34-
```
21+
Run `yarn build` and confirm no errors present from the proposed changes.
3522

36-
You can preview the production build with `npm run preview`.
23+
Confirm vercel build within PR builds without error and check instance deployment for accuracy.
3724

38-
> To deploy your app, you may need to install an [adapter](https://kit.svelte.dev/docs/adapters) for your target environment.
25+
PR should target branch [docs-develop](https://github.com/blocknative/web3-onboard/tree/docs-develop).
Lines changed: 41 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
1+
---
2+
sidebar_title: "Contribution Guide"
3+
---
4+
5+
## How can I contribute to web3-onboard?
6+
7+
### Reporting Bugs
8+
9+
Before creating an issue for a bug, please do a search through the Web3 Onboard issues to make sure that one has not already been created. You may find that someone else has run in to that issue and there may be a fix that has been released in a newer update.
10+
11+
If an issue does not exist for the bug that you want to report, go ahead and create an issue, making sure to add as much detail as possible and following the issue template instructions.
12+
13+
Once an issue has been created, one of the Web3 Onboard maintainers will take a look and will respond typically within a few days. The initial response will usually just acknowledge the issue and will indicate what will happen next.
14+
15+
### Pull Requests
16+
17+
If there is a feature or change that you would like to see in Web3 Onboard, you can fork the repo and make a pull request to have the changes merged in to the main repo and released as part of the official packages.
18+
19+
Once a PR is created, one of the Web3 Onboard maintainers will acknowledge the PR and add it to our sprint planning to be reviewed as soon as possible.
20+
21+
### How can I get a new wallet added?
22+
23+
Web3 Onboard does not require a wallet to be a part of the main codebase to work, so a wallet module can be created and used for your project without needing anything to happen within the Web3Onboard codebase. If you would like the wallet to be part of the official Web3 Onboard packages and repo, then create a pull request, and make sure to add any documentation updates by creating a docs pull request.
24+
25+
If the wallet you are adding is an “injected” wallet (browser extension, mobile dapp browser wallet), you can add a wallet to the injected wallets module. [See here for an example of an injected wallets pull request.](https://github.com/blocknative/web3-onboard/pull/1177/files) You should also add the wallet to the [natively supported injected wallets list](https://onboard.blocknative.com/docs/packages/injected#injected-wallets-supported-natively).
26+
27+
Otherwise if the wallet you are adding requires adding dependencies and initialization (SDK), then you will need to create a new package in the Web3 Onboard monorepo. [See here for an example of a pull request.](https://github.com/blocknative/web3-onboard/pull/1238/files)
28+
29+
If you cannot write the code yourself to add a new wallet, then go ahead and create a feature request issue which may be considered by the maintainers or someone else in the community.
30+
31+
### Documentation contributions
32+
33+
In order to contribute to the docs, you'll have to create a PR on the [docs-develop branch](https://github.com/blocknative/web3-onboard/tree/docs-develop). If you contribute code, you should definitely document it appropriately. We highly encourage the community to improve web3-onboard docs, if you have any questions don't hesitate to reach out.
34+
35+
## Feedback
36+
37+
Jump in to our discord server to provide any feedback you feel is worth sharing. Could the docs be improved? Did you have trouble integrating? Feature requests etc.
38+
39+
## Support
40+
41+
For general questions about how to use Web3 Onboard you can first check out our [docs](https://onboard.blocknative.com/docs/overview/introduction#features) to see if there is an answer there, or you can head to our [Discord](https://discord.com/invite/KZaBVME) for support from the Blocknative team

docs/src/routes/docs/[...1]overview/[...2]onboard.js-migration-guide.md renamed to docs/src/routes/docs/[...1]overview/[...3]onboard.js-migration-guide.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
sidebar_title: "Migration Guide: Web3-Onboard"
2+
sidebar_title: "Migration Guide from v1"
33
---
44
# Migration Guide from onboard.js to web3-onboard
55

0 commit comments

Comments
 (0)