[core-v2.3.0-alpha.2, react-v2.2.0-alpha.2, vue-v2.1.0-alpha.2] : Fix - Validation to handle onclick and links properly (#1083)

* Update validation to handle onclick and links properly
* Update react package version
* Update onClick for notifications to be camel case

Author: Adamj1232

packages/core/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@web3-onboard/core",
-  "version": "2.3.0-alpha.1",
+  "version": "2.3.0-alpha.2",
   "scripts": {
     "build": "rollup -c",
     "dev": "rollup -c -w",

packages/core/src/types.ts

@@ -180,7 +180,7 @@ export type Notification = {
   message: string
   autoDismiss: number
   link?: string
-  onclick?: (event: Event) => void
+  onClick?: (event: Event) => void
 }
 
 export type TransactionHandlerReturn = CustomNotification | boolean | void

packages/core/src/validation.ts

@@ -189,7 +189,9 @@ const customNotificationUpdate = Joi.object({
   eventCode: Joi.string(),
   message: Joi.string().required(),
   id: Joi.string().required(),
-  autoDismiss: Joi.number()
+  autoDismiss: Joi.number(),
+  onClick: Joi.function(),
+  link: Joi.string()
 })
 
 const customNotification = Joi.object({
@@ -198,7 +200,9 @@ const customNotification = Joi.object({
   eventCode: Joi.string(),
   message: Joi.string(),
   id: Joi.string(),
-  autoDismiss: Joi.number()
+  autoDismiss: Joi.number(),
+  onClick: Joi.function(),
+  link: Joi.string()
 })
 
 const notification = Joi.object({
@@ -209,7 +213,9 @@ const notification = Joi.object({
   message: Joi.string().required(),
   autoDismiss: Joi.number().required(),
   network: Joi.string().required(),
-  startTime: Joi.number()
+  startTime: Joi.number(),
+  onClick: Joi.function(),
+  link: Joi.string()
 })
 
 const transactionHandlerReturn = Joi.any().allow(

packages/core/src/views/notify/Notification.svelte

@@ -103,8 +103,8 @@
 </style>
 
 <div
-  class:bn-notify-clickable={notification.onclick}
-  on:click={e => notification.onclick && notification.onclick(e)}
+  class:bn-notify-clickable={notification.onClick}
+  on:click={e => notification.onClick && notification.onClick(e)}
   class="bn-notify-notification bn-notify-notification-{notification.type}}"
 >
   <StatusIconBadge

packages/demo/package.json

@@ -23,7 +23,7 @@
   },
   "dependencies": {
     "@web3-onboard/coinbase": "^2.0.5-alpha.1",
-    "@web3-onboard/core": "^2.3.0-alpha.1",
+    "@web3-onboard/core": "^2.3.0-alpha.2",
     "@web3-onboard/dcent": "^2.0.2-alpha.1",
     "@web3-onboard/fortmatic": "^2.0.4-alpha.1",
     "@web3-onboard/gnosis": "^2.0.3-alpha.1",

packages/react/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@web3-onboard/react",
-  "version": "2.2.0-alpha.2",
+  "version": "2.2.0-alpha.3",
   "description": "Collection of React Hooks for web3-onboard",
   "module": "dist/index.js",
   "browser": "dist/index.js",
@@ -23,7 +23,7 @@
     "typescript": "^4.5.5"
   },
   "dependencies": {
-    "@web3-onboard/core": "^2.3.0-alpha.1",
+    "@web3-onboard/core": "^2.3.0-alpha.2",
     "@web3-onboard/common": "^2.1.2-alpha.2",
     "use-sync-external-store": "1.0.0"
   },

packages/vue/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@web3-onboard/vue",
-  "version": "2.1.0-alpha.1",
+  "version": "2.1.0-alpha.2",
   "description": "Vue Composable for web3-onboard",
   "module": "dist/index.js",
   "browser": "dist/index.js",
@@ -24,7 +24,7 @@
     "@vueuse/core": "^8.4.2",
     "@vueuse/rxjs": "^8.2.0",
     "@web3-onboard/common": "^2.1.2-alpha.2",
-    "@web3-onboard/core": "^2.3.0-alpha.1",
+    "@web3-onboard/core": "^2.3.0-alpha.2",
     "vue-demi": "^0.12.4"
   },
   "peerDependencies": {