Skip to content

Commit ca2b510

Browse files
mhughdoAdamj1232
andauthored
Fix the connect modal getting covered by the bottom bar (#2057)
* fix the connect modal being covered by the bottom bar * pump the package version * feat: remove .mobile-safari class * bump packages' version * bump the version of @web3-onboard/core in other packages --------- Co-authored-by: Adam Carpenter <[email protected]>
1 parent 5b52b93 commit ca2b510

File tree

7 files changed

+11
-19
lines changed

7 files changed

+11
-19
lines changed

packages/core/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@web3-onboard/core",
3-
"version": "2.21.2",
3+
"version": "2.21.3-alpha.1",
44
"description": "Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardized spec compliant web3 providers for all supported wallets, framework agnostic modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.",
55
"keywords": [
66
"Ethereum",

packages/core/src/views/connect/Index.svelte

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -424,10 +424,6 @@
424424
scrollContainer && scrollContainer.scrollTo(0, 0)
425425
}
426426
427-
const isSafariMobile =
428-
device.type === 'mobile' &&
429-
device.browser.name &&
430-
device.browser.name === 'Safari'
431427
</script>
432428

433429
<style>
@@ -532,11 +528,6 @@
532528
.scroll-container::-webkit-scrollbar {
533529
display: none; /* Chrome, Safari and Opera */
534530
}
535-
.mobile-safari {
536-
/* Handles for Mobile Safari's floating Address Bar
537-
covering the bottom of the connect modal **/
538-
padding-bottom: 80px;
539-
}
540531
541532
@media all and (min-width: 768px) {
542533
.container {
@@ -560,7 +551,7 @@
560551

561552
{#if !autoSelect.disableModals}
562553
<Modal close={!connect.disableClose && close}>
563-
<div class="container" class:mobile-safari={isSafariMobile}>
554+
<div class="container">
564555
{#if connect.showSidebar}
565556
<Sidebar step={$modalStep$} />
566557
{/if}

packages/core/src/views/shared/Modal.svelte

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@
5353
.full-screen-background {
5454
width: 100vw;
5555
height: 100vh;
56+
height: 100dvh;
5657
}
5758
5859
.max-height {

packages/demo/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "demo",
3-
"version": "2.0.9",
3+
"version": "2.0.10",
44
"devDependencies": {
55
"assert": "^2.0.0",
66
"browserify-zlib": "^0.2.0",
@@ -33,7 +33,7 @@
3333
"@web3-onboard/capsule": "2.0.1",
3434
"@web3-onboard/cede-store": "^2.2.0",
3535
"@web3-onboard/coinbase": "^2.2.6",
36-
"@web3-onboard/core": "^2.21.2",
36+
"@web3-onboard/core": "^2.21.3-alpha.1",
3737
"@web3-onboard/dcent": "^2.2.7",
3838
"@web3-onboard/enkrypt": "^2.0.3",
3939
"@web3-onboard/fortmatic": "^2.0.18",

packages/react/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@web3-onboard/react",
3-
"version": "2.8.13",
3+
"version": "2.8.14-alpha.1",
44
"description": "A collection of React hooks for integrating Web3-Onboard in to React and Next.js projects. Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardised spec compliant web3 providers for all supported wallets, modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.",
55
"keywords": [
66
"Ethereum",
@@ -62,7 +62,7 @@
6262
},
6363
"dependencies": {
6464
"@web3-onboard/common": "^2.3.3",
65-
"@web3-onboard/core": "^2.21.2",
65+
"@web3-onboard/core": "^2.21.3-alpha.1",
6666
"use-sync-external-store": "1.0.0"
6767
},
6868
"peerDependencies": {

packages/solid/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@web3-onboard/solid",
3-
"version": "2.0.0",
3+
"version": "2.0.1-alpha.1",
44
"description": "A collection of solid Composables for integrating Web3-Onboard in to a Solid project. Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardized spec compliant web3 providers for all supported wallets, modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.",
55
"keywords": [
66
"Ethereum",
@@ -63,7 +63,7 @@
6363
},
6464
"dependencies": {
6565
"@web3-onboard/common": "^2.3.3",
66-
"@web3-onboard/core": "^2.21.0",
66+
"@web3-onboard/core": "^2.21.3-alpha.1",
6767
"solid-js": "^1.8.1"
6868
}
6969
}

packages/vue/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@web3-onboard/vue",
3-
"version": "2.7.12",
3+
"version": "2.7.13-alpha.1",
44
"description": "A collection of Vue Composables for integrating Web3-Onboard in to a Vue or Nuxt project. Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardized spec compliant web3 providers for all supported wallets, modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.",
55
"keywords": [
66
"Ethereum",
@@ -62,7 +62,7 @@
6262
"@vueuse/core": "^8.4.2",
6363
"@vueuse/rxjs": "^8.2.0",
6464
"@web3-onboard/common": "^2.3.3",
65-
"@web3-onboard/core": "^2.21.2",
65+
"@web3-onboard/core": "^2.21.3-alpha.1",
6666
"vue-demi": "^0.12.4"
6767
},
6868
"peerDependencies": {

0 commit comments

Comments
 (0)