FEATURE: Add Tally Ho Wallet Package (#1238)

* Add Tally Ho package
* Remove unneccesary code
* Update references
* Fix build error and bump tallyho-detect-provider package
* Remove yarn.lock
* Fix version and package dependency issues
* Format with prettier
* Revert prettier changes to sequencer package
* Add CI
* Revert prettier changes to wallet connect package
* Add alpha tag to tallyho version
* Update demo versions
* Bump common pkg version in Tally package to latest
Co-authored-by: Adam Carpenter <[email protected]>

Author: 0xzoz

.circleci/config.yml

@@ -303,6 +303,12 @@ jobs:
     working_directory: ~/web3-onboard-monorepo/packages/sequence
     steps:
       - node-build-steps
+  build-tallyho:
+    docker:
+      - image: cimg/node:16.13.1
+    working_directory: ~/web3-onboard-monorepo/packages/tallyho
+    steps:
+      - node-build-steps
 
   # Build staging/Alpha releases
   build-staging-core:
@@ -443,6 +449,12 @@ jobs:
     working_directory: ~/web3-onboard-monorepo/packages/sequence
     steps:
       - node-staging-build-steps
+  build-staging-tallyho:
+    docker:
+      - image: cimg/node:16.13.1
+    working_directory: ~/web3-onboard-monorepo/packages/tallyho
+    steps:
+      - node-staging-build-steps
 
 workflows:
   version: 2
@@ -585,3 +597,9 @@ workflows:
           <<: *deploy_production_filters
       - build-staging-sequence:
           <<: *deploy_staging_filters
+  tallyho:
+    jobs:
+      - build-tallyho:
+          <<: *deploy_production_filters
+      - build-staging-tallyho:
+          <<: *deploy_staging_filters

README.md

@@ -96,6 +96,7 @@ For full documentation, check out the README.md for each package:
 - [MEW](packages/mew/README.md)
 - [Web3Auth](packages/web3auth/README.md)
 - [Sequence](packages/sequence/README.md)
+- [TallyHo](packages/tallyho/README.md)
 
 **Hardware Wallets**
 

packages/demo/package.json

@@ -37,6 +37,7 @@
     "@web3-onboard/sequence": "^2.0.1",
     "@web3-onboard/torus": "^2.1.2",
     "@web3-onboard/trezor": "^2.3.0",
+    "@web3-onboard/tallyho": "^2.0.0-alpha.1",
     "@web3-onboard/walletconnect": "^2.1.2",
     "@web3-onboard/web3auth": "^2.1.2",
     "vconsole": "^3.9.5"

packages/demo/src/App.svelte

@@ -16,6 +16,7 @@
   import gas from '@web3-onboard/gas'
   import dcentModule from '@web3-onboard/dcent'
   import sequenceModule from '@web3-onboard/sequence'
+  import tallyHoModule from '@web3-onboard/tallyho'
   import {
     recoverAddress,
     arrayify,
@@ -84,6 +85,7 @@
   const keepkey = keepkeyModule()
   const keystone = keystoneModule()
   const gnosis = gnosisModule()
+  const tallyho = tallyHoModule()
 
   const trezorOptions = {
     email: '[email protected]',
@@ -118,7 +120,8 @@
       torus,
       gnosis,
       dcent,
-      sequence
+      sequence,
+      tallyho
     ],
     gas,
     chains: [

packages/injected/src/constants.ts

@@ -13,5 +13,5 @@ export const WALLET_NAMES: { [key: string]: string } = {
   meetone: 'MeetOne',
   frame: 'Frame',
   bitkeep: 'BitKeep',
-  sequence: 'Sequence',
+  sequence: 'Sequence'
 }

packages/injected/src/icons/gamestop.ts

@@ -4,4 +4,4 @@ export default `
         <path fill-rule="evenodd" clip-rule="evenodd" d="M7.52862 9.75V15.9646C7.52862 16.4706 7.91965 16.8565 8.4254 16.8565H15.7621C16.2679 16.8565 16.6589 16.4706 16.6589 15.9646V10.7524H17.625V15.9646C17.625 16.9956 16.8045 17.8125 15.7621 17.8125H8.4254C7.38304 17.8125 6.5625 16.9956 6.5625 15.9646V9.75H7.52862Z" fill="white"/>
         <path fill-rule="evenodd" clip-rule="evenodd" d="M6.5625 8.22251C6.5625 7.19176 7.38304 6.375 8.4254 6.375H15.9086V8.64657H16.1323C16.9727 8.64657 17.625 9.29631 17.625 10.1266V10.8949C17.625 11.7253 16.9727 12.375 16.1323 12.375H8.4254C7.38304 12.375 6.5625 11.5582 6.5625 10.5275V8.22251ZM14.9425 8.64657V7.33077H8.4254C7.91965 7.33077 7.52862 7.71661 7.52862 8.22251V10.5275C7.52862 11.0334 7.91965 11.4192 8.4254 11.4192H11.6107V8.64657H14.9425ZM12.5768 11.4192H16.1323C16.4361 11.4192 16.6589 11.2004 16.6589 10.8949V10.1266C16.6589 9.82115 16.4361 9.60235 16.1323 9.60235H12.5768V11.4192Z" fill="white"/>
     </svg>
-`
+`

packages/injected/src/icons/mathwallet.ts

@@ -44,4 +44,4 @@ export default `<svg width="130" height="130" viewBox="0 0 130 130" fill="none"
 </radialGradient>
 </defs>
 </svg>
-`
+`

packages/injected/src/types.ts

@@ -77,7 +77,7 @@ export enum ProviderLabel {
   XDEFI = 'XDEFI Wallet',
   OneInch = '1inch Wallet',
   Tokenary = 'Tokenary Wallet',
-  Tally = 'Tally Wallet',
+  Tally = 'Tally Ho Wallet',
   Rabby = 'Rabby',
   MathWallet = 'MathWallet',
   GameStop = 'GameStop Wallet',
@@ -115,7 +115,7 @@ export interface CustomWindow extends Window {
   xfi: {
     ethereum: InjectedProvider
   }
-  gamestop: InjectedProvider,
+  gamestop: InjectedProvider
   bitkeep: {
     ethereum: InjectedProvider
   }

packages/injected/src/wallets.ts

@@ -94,8 +94,8 @@ const binance: InjectedWalletModule = {
 
     const provider = createEIP1193Provider(window.BinanceChain, {
       eth_chainId: ({ baseRequest }) =>
-        baseRequest({ method: 'eth_chainId' }).then(id =>
-          `0x${parseInt(id as string).toString(16)}`
+        baseRequest({ method: 'eth_chainId' }).then(
+          id => `0x${parseInt(id as string).toString(16)}`
         ),
       // Unsupported method -- will throw error
       eth_selectAccounts: UNSUPPORTED_METHOD,
@@ -512,10 +512,10 @@ const bitkeep: InjectedWalletModule = {
   label: ProviderLabel.BitKeep,
   injectedNamespace: InjectedNameSpace.BitKeep,
   checkProviderIdentity: ({ provider }) =>
-    !!provider && !!provider["ethereum"][ProviderIdentityFlag.BitKeep],
+    !!provider && !!provider['ethereum'][ProviderIdentityFlag.BitKeep],
   getIcon: async () => (await import('./icons/bitkeep.js')).default,
   getInterface: async () => ({
-    provider: window.bitkeep && window.bitkeep.ethereum,
+    provider: window.bitkeep && window.bitkeep.ethereum
   }),
   platforms: ['all']
 }

packages/tallyho/README.json

@@ -0,0 +1,30 @@
+# @web3-onboard/tallyho
+
+## Wallet module for connecting Tally Ho Wallet to web3-onboard
+See [Tally Ho Wallet Developer Docs](https://docs.tally.cash/tally/developers/integrating-dapps)
+
+### Install
+
+`npm i @web3-onboard/tallyho`
+
+
+## Usage
+
+```typescript
+import Onboard from '@web3-onboard/core'
+import tallyHoWalletModule from '@web3-onboard/tallyho'
+
+// initialize the module with options
+const talltHoWalletSdk = tallyHoWalletModule()
+
+const onboard = Onboard({
+  // ... other Onboard options
+  wallets: [
+    tallyHoWalletModule()
+    //... other wallets
+  ]
+})
+
+const connectedWallets = await onboard.connectWallet()
+console.log(connectedWallets)
+```