-
Notifications
You must be signed in to change notification settings - Fork 619
update to use nexus keys instead #8337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to use nexus keys instead #8337
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 10-29-initial_port_of_thirdweb_x402_into_thirdweb-dev_nexus_ #8337 +/- ##
=============================================================================================
Coverage 54.89% 54.90%
=============================================================================================
Files 920 920
Lines 60715 60715
Branches 4129 4136 +7
=============================================================================================
+ Hits 33331 33336 +5
+ Misses 27282 27278 -4
+ Partials 102 101 -1
🚀 New features to boost your workflow:
|
aaf8561 to
ee32d43
Compare
size-limit report 📦
|
ee32d43 to
a0e160f
Compare
a0e160f to
6b211a8
Compare
6b211a8 to
1c10f56
Compare
1c10f56 to
7a26b06
Compare

[SDK] Feature: Update Nexus package to use wallet secret instead of client
Notes for the reviewer
This PR updates the Nexus package to use wallet secret and address directly instead of requiring a ThirdwebClient. Key changes:
facilitator()tocreateFacilitator()with simplified parametershttps://nexus-api.thirdweb.comserverWalletAddressandvaultAccessTokenHow to test
Test the new
createFacilitator()function with wallet secret and address to ensure it properly authenticates with the Nexus API.PR-Codex overview
This PR primarily refactors the payment facilitator logic in the
nexuspackage, updating function imports, modifying type definitions, and enhancing the payment verification process.Detailed summary
sign.tsandfetchWithPayment.tsfiles.package.jsonto removethirdwebdependency.networktype inPaymentArgsfromFacilitatorNetwork | ChaintoFacilitatorNetwork.nexus.ts, including renamingfacilitatortocreateFacilitator.verify-payment.tsandsettle-payment.tsto reflect newcreateFacilitatorstructure.networkToChainIdfunction to accept onlystringtype.stringifyandtoUnitsinutils.ts.createFacilitatorto use new authentication headers structure.