Export ERC7702 MinimalAccount helpers and events #8227
Conversation
Added exports for ERC7702 MinimalAccount generated event and helper modules to both in-app.ts and in-app.native.ts. This includes event exports (Executed, SessionCreated, ValueReceived) and read/write helpers for session and policy management.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
WalkthroughExpanded public exports in two modules to include ERC7702 MinimalAccount events, read/write helpers, account/session helpers and types, and in-app wallet/auth APIs for both web and native targets. Added wallet icon utilities on web. No removals or renames. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
packages/thirdweb/src/exports/wallets/in-app.ts (1)
52-87: Add comprehensive TSDoc with@exampleand a custom annotation tag to all exported APIs.
- packages/thirdweb/src/extensions/erc7702/account/createSessionKey.ts: missing
@exampleand custom tag.- packages/thirdweb/src/extensions/erc7702/account/types.ts: no JSDoc on exported types.
- packages/thirdweb/src/react/core/utils/walletIcon.ts: missing JSDoc/examples for
getSocialIconandsocialIcons.- packages/thirdweb/src/wallets/in-app/web/lib/auth/index.ts: only
getAuthenticatedUseris documented; add JSDoc with@exampleand custom tag forauthenticate,getProfiles,getUserEmail,getUserPhoneNumber,linkProfile,preAuthenticate,unlinkProfile.- packages/thirdweb/src/wallets/in-app/web/lib/auth/passkeys.ts: no JSDoc on
PasskeyWebClientmethods.- packages/thirdweb/src/wallets/in-app/web/in-app.ts: has
@examplebut missing a custom annotation tag.packages/thirdweb/src/exports/wallets/in-app.native.ts (1)
61-83: Add missing@exampleblock to hasStoredPasskey
ThehasStoredPasskeyexport inpackages/thirdweb/src/wallets/in-app/native/auth/passkeys.tslacks an@examplesnippet; add a usage example per TSDoc guidelines.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
packages/thirdweb/src/exports/wallets/in-app.native.ts(1 hunks)packages/thirdweb/src/exports/wallets/in-app.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each file to one stateless, single-responsibility function for clarity
Re-use shared types from@/typesor localtypes.tsbarrels
Prefer type aliases over interface except for nominal shapes
Avoidanyandunknownunless unavoidable; narrow generics when possible
Choose composition over inheritance; leverage utility types (Partial,Pick, etc.)
Comment only ambiguous logic; avoid restating TypeScript in prose
**/*.{ts,tsx}: Use explicit function declarations and explicit return types in TypeScript
Limit each file to one stateless, single‑responsibility function
Re‑use shared types from@/typeswhere applicable
Prefertypealiases overinterfaceexcept for nominal shapes
Avoidanyandunknownunless unavoidable; narrow generics when possible
Prefer composition over inheritance; use utility types (Partial, Pick, etc.)
Lazy‑import optional features and avoid top‑level side‑effects to reduce bundle size
Files:
packages/thirdweb/src/exports/wallets/in-app.native.tspackages/thirdweb/src/exports/wallets/in-app.ts
packages/thirdweb/src/exports/**
📄 CodeRabbit inference engine (CLAUDE.md)
packages/thirdweb/src/exports/**: Export everything viaexports/directory, grouped by feature in the SDK public API
Every public symbol must have comprehensive TSDoc with at least one@exampleblock that compiles and custom annotation tags (@beta,@internal,@experimental)
Files:
packages/thirdweb/src/exports/wallets/in-app.native.tspackages/thirdweb/src/exports/wallets/in-app.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (CLAUDE.md)
Load heavy dependencies inside async paths to keep initial bundle lean (lazy loading)
Files:
packages/thirdweb/src/exports/wallets/in-app.native.tspackages/thirdweb/src/exports/wallets/in-app.ts
packages/thirdweb/**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
packages/thirdweb/**/*.{ts,tsx}: Every public symbol must have comprehensive TSDoc with at least one compiling@exampleand a custom tag (@beta,@internal,@experimental, etc.)
Comment only ambiguous logic; avoid restating TypeScript in prose
Lazy‑load heavy dependencies inside async paths (e.g.,const { jsPDF } = await import("jspdf"))
Files:
packages/thirdweb/src/exports/wallets/in-app.native.tspackages/thirdweb/src/exports/wallets/in-app.ts
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : EIP-1193, EIP-5792, EIP-7702 standard support in wallet modules
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Unified `Wallet` and `Account` interfaces in wallet architecture
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : EIP-1193, EIP-5792, EIP-7702 standard support in wallet modules
Applied to files:
packages/thirdweb/src/exports/wallets/in-app.native.tspackages/thirdweb/src/exports/wallets/in-app.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: Build Packages
- GitHub Check: Lint Packages
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Unit Tests
- GitHub Check: Size
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Analyze (javascript)
🔇 Additional comments (3)
packages/thirdweb/src/exports/wallets/in-app.ts (1)
61-64: LGTM: Web-specific social icon exports.The social icon utilities are appropriately included only in the web export file, correctly differentiating from the native version.
packages/thirdweb/src/exports/wallets/in-app.native.ts (2)
3-60: LGTM: Consistent ERC7702 and account exports.Lines 3-60 correctly mirror the web version, maintaining consistency across platforms for the ERC7702 helpers and account types.
61-83: LGTM: Native-specific exports are correctly scoped.The native version appropriately excludes social icon exports and imports from
native/paths instead ofweb/, correctly differentiating the two platforms.
size-limit report 📦
|
0xFirekeeper
added
the
hotfix
Merge activity
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8227 +/- ##
=======================================
Coverage 55.02% 55.02%
=======================================
Files 919 919
Lines 60583 60583
Branches 4126 4125 -1
=======================================
Hits 33333 33333
- Misses 27146 27147 +1
+ Partials 104 103 -1
🚀 New features to boost your workflow:
|
Added exports for ERC7702 MinimalAccount generated event and helper modules to both in-app.ts and in-app.native.ts. This includes event exports (Executed, SessionCreated, ValueReceived) and read/write helpers for session and policy management.
PR-Codex overview
This PR adds various exports related to the
erc7702extension for theMinimalAccount. It introduces new event and helper functions for managing sessions and policies for signers.Detailed summary
executedEvent,sessionCreatedEvent,valueReceivedEvent.Summary by CodeRabbit