-
Notifications
You must be signed in to change notification settings - Fork 619
Version Packages #7889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Packages #7889
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughThis PR removes a changeset file, updates package versions for thirdweb, nebula, and wagmi-adapter, and adds corresponding changelog entries indicating dependency updates and version bumps. No source code, logic, or API changes are included. Changes
Sequence Diagram(s)Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changesSuggested labels
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/thirdweb/CHANGELOG.md (1)
3-8: Make the changelog entry self-explanatory (expand “fix: #7886”).Right now the line only says “fix: #7886”, which is terse for end users scanning the changelog. Consider briefly describing the fix (e.g., correcting the Mode chain ID definition) and standardizing capitalization (“Fix:” vs “fix:”) to match most entries.
Apply this diff to clarify the note while keeping links intact:
## 5.105.36 ### Patch Changes -- [#7887](https://github.com/thirdweb-dev/js/pull/7887) [`e01af9d`](https://github.com/thirdweb-dev/js/commit/e01af9db7128a66b8bc7297911f713eb828da3cc) Thanks [@leo-shi-dacheng](https://github.com/leo-shi-dacheng)! - fix: #7886 +- [#7887](https://github.com/thirdweb-dev/js/pull/7887) [`e01af9d`](https://github.com/thirdweb-dev/js/commit/e01af9db7128a66b8bc7297911f713eb828da3cc) Thanks [@leo-shi-dacheng](https://github.com/leo-shi-dacheng)! - Fix: Correct Mode chain ID in chain definitions (issue #7886) to ensure accurate display and usage.packages/wagmi-adapter/CHANGELOG.md (1)
3-4: Consider adding a brief note under 0.2.133Adding “Version bump only” (or “Updated dependencies”) helps readers scanning the changelog.
Apply this diff to add a one-liner:
## 0.2.133 + +- Version bump only; no functional changes.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (7)
.changeset/calm-glasses-build.md(0 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/calm-glasses-build.md
🧰 Additional context used
📓 Path-based instructions (1)
packages/wagmi-adapter/**
📄 CodeRabbit Inference Engine (CLAUDE.md)
Wagmi ecosystem integration is in
packages/wagmi-adapter/
Files:
packages/wagmi-adapter/CHANGELOG.mdpackages/wagmi-adapter/package.json
🧠 Learnings (1)
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Applied to files:
packages/wagmi-adapter/CHANGELOG.mdpackages/wagmi-adapter/package.json
🪛 LanguageTool
packages/nebula/CHANGELOG.md
[grammar] ~7-~7: There might be a mistake here.
Context: ...af9db7128a66b8bc7297911f713eb828da3cc)]: - [email protected] ## 0.2.35 ### Patch ...
(QB_NEW_EN)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Unit Tests
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Size
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Lint Packages
- GitHub Check: Build Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (4)
packages/nebula/package.json (1)
60-60: Approve version bump & confirm Mode chain-ID fixAll verifications passed:
• packages/thirdweb/package.json shows version 5.105.36
• CHANGELOG.md includes “## 5.105.36”
• Mode chain ID 34443 is defined in packages/thirdweb/src/chains/constants.ts and chain-definitions/mode.ts
• packages/nebula/package.json still references thirdweb asworkspace:*(expected in source); CI/publish should pin it to 5.105.36 in the released tarballNo further code changes needed.
packages/wagmi-adapter/package.json (1)
58-58: Version bump looks goodMetadata-only change to 0.2.133; no API surface affected. Peer ranges already accommodate thirdweb 5.105.36.
packages/thirdweb/package.json (1)
420-420: Mode mainnet ID correctly updated to 34443Verified that the chain definition and constants have been updated with the correct Mode ID, with no stale values remaining:
- packages/thirdweb/src/chains/chain-definitions/mode.ts (line 13):
id: 34443- packages/thirdweb/src/chains/constants.ts (around line 16):
34443, // modeand919, // mode testnetAll references to the old incorrect ID have been replaced.
packages/nebula/CHANGELOG.md (1)
3-9: Changelog entry is consistent with dependency bump0.2.36 correctly documents the dependency update to thirdweb 5.105.36 with the referencing commit. No further action needed.
size-limit report 📦
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7889 +/- ##
=======================================
Coverage 56.53% 56.53%
=======================================
Files 904 904
Lines 58592 58592
Branches 4140 4139 -1
=======================================
Hits 33126 33126
Misses 25360 25360
Partials 106 106
🚀 New features to boost your workflow:
|
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@thirdweb-dev/[email protected]
Patch Changes
e01af9d]:[email protected]
Patch Changes
e01af9dThanks @leo-shi-dacheng! - fix: chain definitions mode id is error #7886@thirdweb-dev/[email protected]
PR-Codex overview
This PR focuses on updating version numbers and changelogs across various packages, specifically incrementing versions and documenting changes related to dependency updates.
Detailed summary
calm-glasses-build.mdfrom.changeset.packages/thirdweb/package.jsonfrom5.105.35to5.105.36.packages/nebula/package.jsonfrom0.2.35to0.2.36.packages/wagmi-adapter/package.jsonfrom0.2.132to0.2.133.packages/nebula/CHANGELOG.mdfor version0.2.36.packages/thirdweb/CHANGELOG.mdfor version5.105.36.Summary by CodeRabbit
Chores
Documentation