-
Notifications
You must be signed in to change notification settings - Fork 619
Version Packages #7814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Packages #7814
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThis change removes a patch that previously allowed the TransactionWidget to skip the payment selection step when the user's balance was sufficient. It updates package versions and changelogs for Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant TransactionWidget
User->>TransactionWidget: Initiate transaction
TransactionWidget->>TransactionWidget: Check user balance
alt Balance sufficient
TransactionWidget->>User: Proceed to next step (no payment selection)
else Balance insufficient
TransactionWidget->>User: Prompt payment selection
end
Note: The above diagram describes the logic that was present before the patch was removed. With this PR, the payment selection step is no longer skipped based on balance. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (7)
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (5)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/wagmi-adapter/CHANGELOG.md (1)
3-4: Add content to the 0.2.127 entryThe new version header is empty. Even for a “no-op” release, include a brief note such as
- Internal: dependency version bump only; no functional changes.
to ensure the changelog remains informative.packages/nebula/CHANGELOG.md (1)
3-9: Optional: enrich CHANGELOG entry for future readers
Consider adding one-line context on why[email protected]matters (e.g., “skips payment selection when balance is sufficient”). Helps consumers scanning the Nebula log understand the indirect impact.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
.changeset/fluffy-bobcats-walk.md(0 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/fluffy-bobcats-walk.md
🧰 Additional context used
📓 Path-based instructions (1)
packages/wagmi-adapter/**
📄 CodeRabbit Inference Engine (CLAUDE.md)
Wagmi ecosystem integration is in
packages/wagmi-adapter/
Files:
packages/wagmi-adapter/CHANGELOG.mdpackages/wagmi-adapter/package.json
🧠 Learnings (11)
📓 Common learnings
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Surface breaking changes prominently in PR descriptions
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : EIP-1193, EIP-5792, EIP-7702 standard support in wallet modules
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Unified `Wallet` and `Account` interfaces in wallet architecture
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Support for in-app wallets (social/email login)
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Smart wallets with account abstraction
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Applied to files:
packages/wagmi-adapter/CHANGELOG.mdpackages/wagmi-adapter/package.json
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/exports/** : Export everything via `exports/` directory, grouped by feature in the SDK public API
Applied to files:
packages/nebula/package.jsonpackages/wagmi-adapter/package.jsonpackages/thirdweb/package.json
📚 Learning: 2025-06-17T18:30:52.976Z
Learnt from: MananTank
PR: thirdweb-dev/js#7356
File: apps/nebula/src/app/not-found.tsx:1-1
Timestamp: 2025-06-17T18:30:52.976Z
Learning: In the thirdweb/js project, the React namespace is available for type annotations (like React.FC) without needing to explicitly import React. This is project-specific configuration that differs from typical TypeScript/React setups.
Applied to files:
packages/nebula/package.jsonpackages/wagmi-adapter/package.jsonpackages/thirdweb/package.json
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/exports/** : Every public symbol must have comprehensive TSDoc with at least one `example` block that compiles and custom annotation tags (`beta`, `internal`, `experimental`)
Applied to files:
packages/nebula/package.jsonpackages/wagmi-adapter/package.jsonpackages/thirdweb/package.json
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/react-native-adapter/** : Mobile platform shims are in `packages/react-native-adapter/`
Applied to files:
packages/wagmi-adapter/package.json
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Surface breaking changes prominently in PR descriptions
Applied to files:
packages/nebula/CHANGELOG.mdpackages/thirdweb/package.jsonpackages/thirdweb/CHANGELOG.md
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : EIP-1193, EIP-5792, EIP-7702 standard support in wallet modules
Applied to files:
packages/thirdweb/CHANGELOG.md
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Unified `Wallet` and `Account` interfaces in wallet architecture
Applied to files:
packages/thirdweb/CHANGELOG.md
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Smart wallets with account abstraction
Applied to files:
packages/thirdweb/CHANGELOG.md
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Support for in-app wallets (social/email login)
Applied to files:
packages/thirdweb/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: Size
- GitHub Check: Build Packages
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Unit Tests
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (4)
packages/wagmi-adapter/package.json (1)
55-59: Version bump looks goodThe patch increment to
0.2.127is recorded correctly and aligns with the CHANGELOG. No further manifest updates required.packages/thirdweb/package.json (1)
412-413: Version bump looks good and is internally consistent
The patch bump to5.105.30aligns with the referenced CHANGELOG entry and nothing else in this manifest needs adjusting. ✅packages/nebula/package.json (1)
60-61: Nebula version bumped correctly
0.2.30correctly tracks the workspace-wide update and no other manifest fields require changes.packages/thirdweb/CHANGELOG.md (1)
3-8: Changelog entry looks goodVersion header, patch-changes section, PR/commit links, and concise description are all present and correctly formatted. Nothing to add here.
size-limit report 📦
|
8055840 to
91542d3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7814 +/- ##
=======================================
Coverage 56.33% 56.33%
=======================================
Files 905 905
Lines 58821 58821
Branches 4144 4144
=======================================
Hits 33137 33137
Misses 25578 25578
Partials 106 106
🚀 New features to boost your workflow:
|
91542d3 to
20e8c43
Compare
20e8c43 to
b3e7a3a
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@thirdweb-dev/[email protected]
Patch Changes
e114b2c]:[email protected]
Patch Changes
e114b2cThanks @gregfromstl! - Skips payment selection in the TransactionWidget if the user's balance is sufficient to complete the transaction.@thirdweb-dev/[email protected]
PR-Codex overview
This PR focuses on updating version numbers and changelogs for several packages, reflecting the latest changes and dependency updates.
Detailed summary
fluffy-bobcats-walk.mdfrom.changeset.packages/thirdweb/package.jsonfrom5.105.29to5.105.30.packages/nebula/package.jsonfrom0.2.29to0.2.30.packages/wagmi-adapter/package.jsonfrom0.2.126to0.2.127.nebulaversion0.2.30with dependency update to[email protected].thirdwebversion5.105.30detailing a change in theTransactionWidget.Summary by CodeRabbit