[SDK] Optimize 4337 signature performance

Author: joaquim-verges

.changeset/thirty-eels-decide.md

@@ -0,0 +1,5 @@
+---
+"thirdweb": patch
+---
+
+Optimize 4337 signature performance

packages/thirdweb/src/wallets/smart/lib/signing.ts

@@ -1,9 +1,6 @@
 import type * as ox__TypedData from "ox/TypedData";
 import { serializeErc6492Signature } from "../../../auth/serialize-erc6492-signature.js";
-import {
-  verifyEip1271Signature,
-  verifyHash,
-} from "../../../auth/verify-hash.js";
+import { verifyEip1271Signature } from "../../../auth/verify-hash.js";
 import type { Chain } from "../../../chains/types.js";
 import type { ThirdwebClient } from "../../../client/client.js";
 import {
@@ -50,7 +47,7 @@ export async function smartAccountSignMessage({
   if (is712Factory) {
     const wrappedMessageHash = encodeAbiParameters(
       [{ type: "bytes32" }],
-      [originalMsgHash],
+      [originalMsgHash]
     );
 
     sig = await options.personalAccount.signTypedData({
@@ -96,19 +93,7 @@ export async function smartAccountSignMessage({
       signature: sig,
     });
 
-    // check if the signature is valid
-    const isValid = await verifyHash({
-      address: accountContract.address,
-      chain: accountContract.chain,
-      client: accountContract.client,
-      hash: originalMsgHash,
-      signature: erc6492Sig,
-    });
-
-    if (isValid) {
-      return erc6492Sig;
-    }
-    throw new Error("Unable to verify ERC-6492 signature after signing.");
+    return erc6492Sig;
   }
 }
 
@@ -149,7 +134,7 @@ export async function smartAccountSignTypedData<
   if (is712Factory) {
     const wrappedMessageHash = encodeAbiParameters(
       [{ type: "bytes32" }],
-      [originalMsgHash],
+      [originalMsgHash]
     );
     sig = await options.personalAccount.signTypedData({
       domain: {
@@ -194,21 +179,7 @@ export async function smartAccountSignTypedData<
       signature: sig,
     });
 
-    // check if the signature is valid
-    const isValid = await verifyHash({
-      address: accountContract.address,
-      chain: accountContract.chain,
-      client: accountContract.client,
-      hash: originalMsgHash,
-      signature: erc6492Sig,
-    });
-
-    if (isValid) {
-      return erc6492Sig;
-    }
-    throw new Error(
-      "Unable to verify signature on smart account, please make sure the admin wallet has permissions and the signature is valid.",
-    );
+    return erc6492Sig;
   }
 }
 
@@ -225,7 +196,7 @@ export async function confirmContractDeployment(args: {
   while (!isDeployed) {
     if (Date.now() - startTime > timeout) {
       throw new Error(
-        "Timeout: Smart account deployment not confirmed after 1 minute",
+        "Timeout: Smart account deployment not confirmed after 1 minute"
       );
     }
     await new Promise((resolve) => setTimeout(resolve, 500));