Skip to content

Commit e7d0899

Browse files
committed
[MNY-163] Portal: Fix broken links in payments sidebar (#8021)
<!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the `sidebar` configuration in two files: `sidebar.tsx` for the bridge and payments sections. It removes an entry and modifies the `href` properties for navigation links to ensure correct routing. ### Detailed summary - Removed the `Playground` entry from the `sidebar` in `apps/portal/src/app/bridge/sidebar.tsx`. - Updated the `href` for the `Playground` entry in `apps/portal/src/app/payments/sidebar.tsx` to point to `/payments`. - Changed `href` values for `Sell Tokens`, `Swap Tokens`, `Get Token Prices`, and `Get Routes` to use absolute paths. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Corrected Payments sidebar destinations: Playground now points to the dedicated payments playground, and Bridge-related items use absolute paths for reliable, consistent navigation across the app. * **Chores** * Removed the obsolete Playground link from the Bridge sidebar to streamline navigation. * Cleaned up an unused icon import. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1 parent 88001cf commit e7d0899

File tree

2 files changed

+6
-11
lines changed

2 files changed

+6
-11
lines changed

apps/portal/src/app/bridge/sidebar.tsx

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { ExternalLinkIcon, ZapIcon } from "lucide-react";
1+
import { ZapIcon } from "lucide-react";
22
import type { SideBar } from "@/components/Layouts/DocLayout";
33
import { EngineIcon, ReactIcon, TypeScriptIcon, UnityIcon } from "@/icons";
44
import { UnrealEngineIcon } from "../../icons/sdks/UnrealEngineIcon";
@@ -12,11 +12,6 @@ export const sidebar: SideBar = {
1212
name: "Get Started",
1313
icon: <ZapIcon />,
1414
},
15-
{
16-
href: "https://playground.thirdweb.com/",
17-
icon: <ExternalLinkIcon />,
18-
name: "Playground",
19-
},
2015
{ separator: true },
2116
{
2217
isCollapsible: false,

apps/portal/src/app/payments/sidebar.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ export const sidebar: SideBar = {
1313
icon: <ZapIcon />,
1414
},
1515
{
16-
href: "https://playground.thirdweb.com/",
16+
href: "https://playground.thirdweb.com/payments",
1717
icon: <ExternalLinkIcon />,
1818
name: "Playground",
1919
},
@@ -38,19 +38,19 @@ export const sidebar: SideBar = {
3838
name: "Send a Payment",
3939
},
4040
{
41-
href: `bridge/sell`,
41+
href: `/bridge/sell`,
4242
name: "Sell Tokens",
4343
},
4444
{
45-
href: `bridge/swap`,
45+
href: `/bridge/swap`,
4646
name: "Swap Tokens",
4747
},
4848
{
49-
href: `bridge/tokens`,
49+
href: `/bridge/tokens`,
5050
name: "Get Token Prices",
5151
},
5252
{
53-
href: `bridge/routes`,
53+
href: `/bridge/routes`,
5454
name: "Get Routes",
5555
},
5656
{

0 commit comments

Comments
 (0)