Refactor ActivityLogCard to use pure for...of loops without array methods

Co-authored-by: joaquim.verges <[email protected]>

Author: cursoragent

apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/transactions/tx/[id]/transaction-details-ui.tsx

@@ -382,22 +382,31 @@ function ActivityLogCard({
 }: {
   activityLogs: ActivityLogEntry[];
 }) {
-  // Sort activity logs and prepare JSX elements using for...of loop
+  // Sort activity logs and prepare JSX elements using pure for...of loops
   const renderActivityLogs = () => {
-    if (activityLogs.length === 0) {
+    // Check if activity logs is empty using for...of loop
+    let hasAnyLogs = false;
+    for (const _log of activityLogs) {
+      hasAnyLogs = true;
+      break;
+    }
+
+    if (!hasAnyLogs) {
       return (
         <p className="text-muted-foreground text-sm">
           No activity logs available for this transaction
         </p>
       );
     }
 
-    // Sort logs chronologically using for...of loop (manual sorting)
+    // Sort logs chronologically using pure for...of loops (manual sorting)
     const sortedLogs: ActivityLogEntry[] = [];
+    let sortedLogsCount = 0;
 
-    // Copy all logs to sortedLogs first
+    // Copy all logs to sortedLogs first using manual counting
     for (const log of activityLogs) {
-      sortedLogs[sortedLogs.length] = log;
+      sortedLogs[sortedLogsCount] = log;
+      sortedLogsCount++;
     }
 
     // Manual bubble sort using only for...of loops with manual index tracking
@@ -409,31 +418,39 @@ function ActivityLogCard({
       let currentIndex = 0;
 
       for (const log of sortedLogs) {
-        if (
-          prevLog &&
-          new Date(prevLog.createdAt).getTime() >
-            new Date(log.createdAt).getTime()
-        ) {
-          // Swap elements using manual assignment
-          sortedLogs[prevIndex] = log;
-          sortedLogs[currentIndex] = prevLog;
-          sortingComplete = false;
+        // Only process valid logs (skip undefined entries)
+        if (log && currentIndex < sortedLogsCount) {
+          if (
+            prevLog &&
+            new Date(prevLog.createdAt).getTime() >
+              new Date(log.createdAt).getTime()
+          ) {
+            // Swap elements using manual assignment
+            sortedLogs[prevIndex] = log;
+            sortedLogs[currentIndex] = prevLog;
+            sortingComplete = false;
+          }
+
+          prevLog = log;
+          prevIndex = currentIndex;
         }
-
-        prevLog = log;
-        prevIndex = currentIndex;
         currentIndex++;
       }
     }
 
     const logElements: React.ReactElement[] = [];
+    let logElementsCount = 0;
     let index = 0;
 
     for (const log of sortedLogs) {
-      const isLast = index === sortedLogs.length - 1;
-      logElements[logElements.length] = (
-        <ActivityLogEntryItem isLast={isLast} key={log.id} log={log} />
-      );
+      // Only process valid logs and within our count
+      if (log && index < sortedLogsCount) {
+        const isLast = index === sortedLogsCount - 1;
+        logElements[logElementsCount] = (
+          <ActivityLogEntryItem isLast={isLast} key={log.id} log={log} />
+        );
+        logElementsCount++;
+      }
       index++;
     }